Patchwork [Karmic] Input: synaptics - add another Portege M300 to rate blacklist

login
register
mail settings
Submitter Alberto Milone
Date Oct. 15, 2009, 10:28 a.m.
Message ID <200910151228.03298.alberto.milone@canonical.com>
Download mbox | patch
Permalink /patch/36108/
State Accepted
Headers show

Comments

Alberto Milone - Oct. 15, 2009, 10:28 a.m.
Hi all,

Toshiba Portege's keyboard controller can't handle full-rate data stream from 
the synaptics touchpad which makes it very difficult to use the keyboard and 
the touchpad at the same time.

A DMI workaround for this is already in the driver (see the dmi_system_id 
toshiba_dmi_table struct) but it looks like we're missing an identifier (i.e. 
"Portable PC") as reported in LP: #433801.

The attached patch by Dmitry Torokhov (which is scheduled for inclusion in 
mainline) solves the problem.

Can you include it in Karmic, please?

Regards,
Tim Gardner - Oct. 15, 2009, 8:06 p.m.
Alberto Milone wrote:
> Hi all,
> 
> Toshiba Portege's keyboard controller can't handle full-rate data stream from 
> the synaptics touchpad which makes it very difficult to use the keyboard and 
> the touchpad at the same time.
> 
> A DMI workaround for this is already in the driver (see the dmi_system_id 
> toshiba_dmi_table struct) but it looks like we're missing an identifier (i.e. 
> "Portable PC") as reported in LP: #433801.
> 
> The attached patch by Dmitry Torokhov (which is scheduled for inclusion in 
> mainline) solves the problem.
> 
> Can you include it in Karmic, please?
> 
> Regards,
> 
> 

Applied, though you'll have to write the SRU justification in the bug
report or Stefan will be grumpy.

Dmitry - Please Cc stable@kernel.org when you submit your patch.

rtg
Alberto Milone - Oct. 18, 2009, 9:34 a.m.
On Thursday 15 Oct 2009 22:06:04 Tim Gardner wrote:
> Alberto Milone wrote:
> > Hi all,
> >
> > Toshiba Portege's keyboard controller can't handle full-rate data stream
> > from the synaptics touchpad which makes it very difficult to use the
> > keyboard and the touchpad at the same time.
> >
> > A DMI workaround for this is already in the driver (see the dmi_system_id
> > toshiba_dmi_table struct) but it looks like we're missing an identifier
> > (i.e. "Portable PC") as reported in LP: #433801.
> >
> > The attached patch by Dmitry Torokhov (which is scheduled for inclusion
> > in mainline) solves the problem.
> >
> > Can you include it in Karmic, please?
> >
> > Regards,
> 
> Applied, though you'll have to write the SRU justification in the bug
> report or Stefan will be grumpy.
> 
> Dmitry - Please Cc stable@kernel.org when you submit your patch.
> 
> rtg
> 
Thanks a lot, Tim.

This means that the patch will enter Karmic after its release (as you 
mentioned an SRU rather than a FFE), right?

Regards,

Patch

Input: synaptics - add another Protege M300 to rate blacklist

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Apparently some of Toshiba Protege M300 identify themselves as
"Portable PC" in DMI so we need to add that to the DMI table as
well. We need DMI data so we can automatically lower Synaptics
reporting rate from 80 to 40 pps to avoid over-taxing their
keyboard controllers.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 drivers/input/mouse/synaptics.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)


diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index b66ff1a..f4a6125 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -652,6 +652,16 @@  static const struct dmi_system_id toshiba_dmi_table[] = {
 			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "PORTEGE M300"),
 		},
+
+	},
+	{
+		.ident = "Toshiba Portege M300",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Portable PC"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Version 1.0"),
+		},
+
 	},
 	{ }
 };