From patchwork Thu Oct 15 10:28:03 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alberto Milone X-Patchwork-Id: 36108 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 64572B7B74 for ; Thu, 15 Oct 2009 21:28:23 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.60) (envelope-from ) id 1MyNZA-0006sz-HP; Thu, 15 Oct 2009 11:28:16 +0100 Received: from mail-fx0-f224.google.com ([209.85.220.224]) by chlorine.canonical.com with esmtp (Exim 4.60) (envelope-from ) id 1MyNZ4-0006sj-Ge for kernel-team@lists.ubuntu.com; Thu, 15 Oct 2009 11:28:10 +0100 Received: by fxm24 with SMTP id 24so854371fxm.35 for ; Thu, 15 Oct 2009 03:28:10 -0700 (PDT) Received: by 10.102.245.35 with SMTP id s35mr4275179muh.124.1255602490089; Thu, 15 Oct 2009 03:28:10 -0700 (PDT) Received: from alberto-desktop.localnet (host97-230-dynamic.59-82-r.retail.telecomitalia.it [82.59.230.97]) by mx.google.com with ESMTPS id u26sm10835mug.32.2009.10.15.03.28.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 15 Oct 2009 03:28:09 -0700 (PDT) From: Alberto Milone To: Ubuntu Kernel Team Subject: [PATCH] [Karmic] Input: synaptics - add another Portege M300 to rate blacklist Date: Thu, 15 Oct 2009 12:28:03 +0200 User-Agent: KMail/1.12.2 (Linux/2.6.31-12-generic-pae; KDE/4.3.2; i686; ; ) MIME-Version: 1.0 Message-Id: <200910151228.03298.alberto.milone@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.8 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com Hi all, Toshiba Portege's keyboard controller can't handle full-rate data stream from the synaptics touchpad which makes it very difficult to use the keyboard and the touchpad at the same time. A DMI workaround for this is already in the driver (see the dmi_system_id toshiba_dmi_table struct) but it looks like we're missing an identifier (i.e. "Portable PC") as reported in LP: #433801. The attached patch by Dmitry Torokhov (which is scheduled for inclusion in mainline) solves the problem. Can you include it in Karmic, please? Regards, Input: synaptics - add another Protege M300 to rate blacklist From: Dmitry Torokhov Apparently some of Toshiba Protege M300 identify themselves as "Portable PC" in DMI so we need to add that to the DMI table as well. We need DMI data so we can automatically lower Synaptics reporting rate from 80 to 40 pps to avoid over-taxing their keyboard controllers. Signed-off-by: Dmitry Torokhov --- drivers/input/mouse/synaptics.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index b66ff1a..f4a6125 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -652,6 +652,16 @@ static const struct dmi_system_id toshiba_dmi_table[] = { DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), DMI_MATCH(DMI_PRODUCT_NAME, "PORTEGE M300"), }, + + }, + { + .ident = "Toshiba Portege M300", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), + DMI_MATCH(DMI_PRODUCT_NAME, "Portable PC"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Version 1.0"), + }, + }, { } };