| Message ID | 1402902112-12487-1-git-send-email-vincent.stehle@laposte.net |
|---|---|
| State | Changes Requested |
| Headers | show |
Dear Vincent Stehlé, On Mon, 16 Jun 2014 09:01:52 +0200, Vincent Stehlé wrote: > This allows to use e.g. convert to generate files at build time. > > Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> > --- > package/imagemagick/imagemagick.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk > index a6f3f45..ae191f1 100644 > --- a/package/imagemagick/imagemagick.mk > +++ b/package/imagemagick/imagemagick.mk > @@ -119,3 +119,4 @@ IMAGEMAGICK_CONF_OPT += --without-bzlib > endif > > $(eval $(autotools-package)) > +$(eval $(host-autotools-package)) My initial reaction to this patch is: "why". We generally have host packages for two situations: * They are used as a dependency to build some other target package. In this case, we expect the patch adding the host package to be submitted alongside the patch adding the target package needing it, so that there is no "unneeded" host package. * They are tools needed to manipulate the target hardware (flashing utilities or special communication tools), to generate filesystem or special images, etc. In this case, they are present in the "Host utilities" submenu of menuconfig. Your package does not fall in any of those categories. How will you trigger the build of this package? By manually calling "make host-imagemagick" ? Best regards, Thomas
Dear Vincent, On Sun, 22 Jun 2014 19:28:05 +0200, Vincent wrote: > > we expect the patch adding the host package to be > > submitted alongside the patch adding the target package needing it, > > so that there is no "unneeded" host package. > > Ah! I did not know about that rule. It makes sense, indeed. > > I am trying to package ev3sources, which needs convert at build time. > I'll re-submit this host-imagemagick patch alongside, then. Ok, no problem. Indeed, host-imagemagick will be perfectly fine when submitted alongside the ev3sources package. In the mean time, I'll mark your patch as "Changes requested" in patchwork. Thanks! Thomas
diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk index a6f3f45..ae191f1 100644 --- a/package/imagemagick/imagemagick.mk +++ b/package/imagemagick/imagemagick.mk @@ -119,3 +119,4 @@ IMAGEMAGICK_CONF_OPT += --without-bzlib endif $(eval $(autotools-package)) +$(eval $(host-autotools-package))
This allows to use e.g. convert to generate files at build time. Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> --- package/imagemagick/imagemagick.mk | 1 + 1 file changed, 1 insertion(+)