| Message ID | 53906ED8.90500@arni.lv |
|---|---|
| State | Rejected |
| Headers | show |
Dear Arni, On Thu, 05 Jun 2014 14:21:28 +0100, Arni wrote: > I'm working on porting Tilera tilegx platform to OpenWRT project, but > I'm sure you are also interested in it. > Patch is very simple, hope someone will find it usefull. Here is the patch : Thanks for this patch! However, adding an architecture to Buildroot is a bit more than just adding those few definitions. I'm mainly thinking: * Toolchain: did you test the internal toolchain backend? Or are external toolchains available? * Packages: how much user-space packages that have architecture-specific code support the tilegx platform? For example, libffi, or strace are such packages. * Support: if we start supporting a new architecture in Buildroot, we try to do it well. One aspect of this is that we would add this architecture to our automated build infrastructure, which tests random combinations of packages. Would you be willing to help fixing the issues that arise through this testing effort? It would be a bit annoying for us to add the support for an architecture, and then have nobody actively interested in it and therefore nobody fixing the various issues. On a more anecdotal note, your Git commit is improperly formatted, because your commit log contains some contents not relevant for a commit log. It should look like just: """ Add support for Tilera tilegx architecture This commit adds support for the tilegx CPU architecture designed by Tilera. Signed-off-by: You <you@domain.com> """ See http://buildroot.org/downloads/manual/manual.html#submitting-patches for details. Thanks! Thomas
Hello Arni, On Sun, 8 Jun 2014 17:22:41 +0200, Thomas Petazzoni wrote: > On Thu, 05 Jun 2014 14:21:28 +0100, Arni wrote: > > > I'm working on porting Tilera tilegx platform to OpenWRT project, but > > I'm sure you are also interested in it. > > Patch is very simple, hope someone will find it usefull. Here is the patch : > > Thanks for this patch! > > However, adding an architecture to Buildroot is a bit more than just > adding those few definitions. I'm mainly thinking: > > * Toolchain: did you test the internal toolchain backend? Or are > external toolchains available? > > * Packages: how much user-space packages that have > architecture-specific code support the tilegx platform? For example, > libffi, or strace are such packages. > > * Support: if we start supporting a new architecture in Buildroot, we > try to do it well. One aspect of this is that we would add this > architecture to our automated build infrastructure, which tests > random combinations of packages. Would you be willing to help fixing > the issues that arise through this testing effort? It would be a bit > annoying for us to add the support for an architecture, and then > have nobody actively interested in it and therefore nobody fixing > the various issues. Since the patch is incomplete, that adding the support for a new architecture in Buildroot involves quite some work beyond just adding a Config.in entry, and that you never replied to my original feedback, I'll mark the patch as Rejected in our patch tracking system for the moment. Should you be interested in seeing the Tilera architecture support merged in Buildroot, please do not hesitate to get back to us. However, we'll have to be convinced that some person will be around to help fixing the Tilera related issues when they show up. Thanks! Thomas Petazzoni
diff --git a/arch/Config.in b/arch/Config.in index 1f60f81..4152267 100644 --- a/arch/Config.in +++ b/arch/Config.in @@ -201,6 +201,13 @@ config BR2_xtensa http://en.wikipedia.org/wiki/Xtensa http://www.tensilica.com/ +config BR2_tilegx + bool "Tile-GX" +# select BR2_ARCH_IS_64 + help + tilera tileGX + + endchoice # The following string values are defined by the individual @@ -360,4 +367,8 @@ if BR2_xtensa source "arch/Config.in.xtensa" endif +if BR2_tilegx +source "arch/Config.in.tilegx" +endif + endmenu # Target options diff --git a/arch/Config.in.tilegx b/arch/Config.in.tilegx new file mode 100644 index 0000000..bdecf64 --- /dev/null +++ b/arch/Config.in.tilegx @@ -0,0 +1,15 @@ + +#config BR2_GCC_TARGET_ARCH +# default "tilegx" + +config BR2_ENDIAN + default "LITTLE" + +config BR2_ARCH + default "tilegx" + +#config BR2_GCC_TARGET_ABI +# default "64" + +#config BR2_GCC_TARGET_CPU +# default "tilegx" diff --git a/linux/linux.mk b/linux/linux.mk index bd3f2ac..5fb9b40 100644 --- a/linux/linux.mk +++ b/linux/linux.mk @@ -120,6 +120,8 @@ ifeq ($(KERNEL_ARCH),i386) KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/x86 else ifeq ($(KERNEL_ARCH),x86_64) KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/x86 +else ifeq ($(KERNEL_ARCH),tilegx) +KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/tile else KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/$(KERNEL_ARCH) endif