| Message ID | 1392803602-5566-2-git-send-email-fabio.porcedda@gmail.com |
|---|---|
| State | Accepted |
| Commit | 551c4ca7a5e4f59120381ade367727ef1ad7ef21 |
| Headers | show |
Dear Fabio Porcedda, On Wed, 19 Feb 2014 10:53:20 +0100, Fabio Porcedda wrote: > Fixes: > http://autobuild.buildroot.net/results/109/109b7c9b575c7362c4982a908a1e3695e7590ebd/ > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > --- > package/libplayer/Config.in | 3 ++- > package/mplayer/Config.in | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/package/libplayer/Config.in b/package/libplayer/Config.in > index 113f650..84dad1d 100644 > --- a/package/libplayer/Config.in > +++ b/package/libplayer/Config.in > @@ -13,7 +13,8 @@ if BR2_PACKAGE_LIBPLAYER > config BR2_PACKAGE_LIBPLAYER_MPLAYER > bool "mplayer backend" > # mplayer > - depends on !BR2_sh4a && !BR2_sh4aeb && !BR2_microblaze && !BR2_aarch64 > + depends on !(BR2_bfin || BR2_sh4a || BR2_sh4aeb || BR2_microblaze || \ > + BR2_aarch64) > # mplayer > depends on BR2_LARGEFILE > # mplayer > diff --git a/package/mplayer/Config.in b/package/mplayer/Config.in > index ae273e4..f2b3620 100644 > --- a/package/mplayer/Config.in > +++ b/package/mplayer/Config.in > @@ -1,7 +1,7 @@ > config BR2_PACKAGE_MPLAYER > bool "mplayer" > # Those architectures are not supported by MPlayer > - depends on !(BR2_sh2a || BR2_sh4a || BR2_sh4aeb \ > + depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \ > || BR2_microblaze || BR2_aarch64 || BR2_nios2) I believe it's time to switch to a different logic. What about: config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS bool depends on <list of supported architectures> and then use "depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS" / "depends on !BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS" all over the place instead of duplicating the list of architectures everywhere. Thomas
>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes: > Fixes: > http://autobuild.buildroot.net/results/109/109b7c9b575c7362c4982a908a1e3695e7590ebd/ > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> Committed, thanks.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > I believe it's time to switch to a different logic. What about: > config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS > bool > depends on <list of supported architectures> I agree this would be a nice cleanup, but I've applied this series for now for 2014.02.
diff --git a/package/libplayer/Config.in b/package/libplayer/Config.in index 113f650..84dad1d 100644 --- a/package/libplayer/Config.in +++ b/package/libplayer/Config.in @@ -13,7 +13,8 @@ if BR2_PACKAGE_LIBPLAYER config BR2_PACKAGE_LIBPLAYER_MPLAYER bool "mplayer backend" # mplayer - depends on !BR2_sh4a && !BR2_sh4aeb && !BR2_microblaze && !BR2_aarch64 + depends on !(BR2_bfin || BR2_sh4a || BR2_sh4aeb || BR2_microblaze || \ + BR2_aarch64) # mplayer depends on BR2_LARGEFILE # mplayer diff --git a/package/mplayer/Config.in b/package/mplayer/Config.in index ae273e4..f2b3620 100644 --- a/package/mplayer/Config.in +++ b/package/mplayer/Config.in @@ -1,7 +1,7 @@ config BR2_PACKAGE_MPLAYER bool "mplayer" # Those architectures are not supported by MPlayer - depends on !(BR2_sh2a || BR2_sh4a || BR2_sh4aeb \ + depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \ || BR2_microblaze || BR2_aarch64 || BR2_nios2) # Broken support for <ARMv5 depends on !(BR2_arm7tdmi || BR2_arm720t || BR2_arm920t \ @@ -29,6 +29,6 @@ config BR2_PACKAGE_MPLAYER_MENCODER endif comment "mplayer needs a toolchain w/ largefile" - depends on !(BR2_sh2 || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \ + depends on !(BR2_bfin || BR2_sh2 || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \ || BR2_microblaze || BR2_aarch64) depends on !BR2_LARGEFILE
Fixes: http://autobuild.buildroot.net/results/109/109b7c9b575c7362c4982a908a1e3695e7590ebd/ Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> --- package/libplayer/Config.in | 3 ++- package/mplayer/Config.in | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-)