| Message ID | 0255f67e72bc626106163b3cfb821a68d99970fd.1389596187.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Commit | 881c487e8817a7c19b0c67684dde5510f871aa52 |
| Headers | show |
Dear Baruch Siach, On Mon, 13 Jan 2014 08:56:27 +0200, Baruch Siach wrote: > + # priority-inheritance mutex needs NPTL > + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD No, these symbols are specific to the internal toolchain backend, and do not make sense for external toolchains. Therefore, they shouldn't be used for package dependencies. Thomas
Hi Thomas, On Mon, Jan 13, 2014 at 04:10:12PM +0800, Thomas Petazzoni wrote: > On Mon, 13 Jan 2014 08:56:27 +0200, Baruch Siach wrote: > > > + # priority-inheritance mutex needs NPTL > > + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD > > No, these symbols are specific to the internal toolchain backend, and > do not make sense for external toolchains. Therefore, they shouldn't be > used for package dependencies. Well, my v1 patch didn't have this dependency. Do you have any better suggestion for the NPTL situation? baruch
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > Dear Baruch Siach, > On Mon, 13 Jan 2014 08:56:27 +0200, Baruch Siach wrote: >> + # priority-inheritance mutex needs NPTL >> + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD > No, these symbols are specific to the internal toolchain backend, and > do not make sense for external toolchains. Therefore, they shouldn't be > used for package dependencies. Notice that the dependency is !BR_THREADS, E.G. only hide if using the internal uClibc toolchain with linuxthreads. That I believe is OK. For external uClibc toolchains we don't know the threads variant, which is why the 2nd line disables it for the specific archs where we know NPTL isn't available.
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes: > Fixes > http://autobuild.buildroot.net/results/8aa/8aaa4b56a53241b7342fede568fbc72a7656cc38/. > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > v2: exclude linuxthreads-{old,new} for internal toolchains (Peter Korsgaard) Committed, thanks.
diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in index 36c111bd200c..58a88a8af182 100644 --- a/package/rt-tests/Config.in +++ b/package/rt-tests/Config.in @@ -1,9 +1,10 @@ config BR2_PACKAGE_RT_TESTS bool "rt-tests" depends on BR2_TOOLCHAIN_HAS_THREADS - # Too old uClibc, does not provide priority-inheritance - # mutexes - depends on !BR2_avr32 + # priority-inheritance mutex needs NPTL + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD + # no NPTL for these archs + depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc help Set of utilities for testing the real-time behaviour of a Linux system. @@ -23,5 +24,6 @@ config BR2_PACKAGE_RT_TESTS http://rt.wiki.kernel.org comment "rt-tests needs a toolchain w/ threads" - depends on !BR2_avr32 + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD + depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc depends on !BR2_TOOLCHAIN_HAS_THREADS
Fixes http://autobuild.buildroot.net/results/8aa/8aaa4b56a53241b7342fede568fbc72a7656cc38/. Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- v2: exclude linuxthreads-{old,new} for internal toolchains (Peter Korsgaard) --- package/rt-tests/Config.in | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)