diff mbox

[4/5] zsh: alpha sort menu option

Message ID 1385981368-2235-4-git-send-email-gustavo@zacarias.com.ar
State Superseded
Headers show

Commit Message

Gustavo Zacarias Dec. 2, 2013, 10:49 a.m. UTC
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Peter Korsgaard Dec. 3, 2013, 8:09 a.m. UTC | #1
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
 > ---
 >  package/Config.in | 4 +++-
 >  1 file changed, 3 insertions(+), 1 deletion(-)

 > diff --git a/package/Config.in b/package/Config.in
 > index a65ceac..e70a58c 100644
 > --- a/package/Config.in
 > +++ b/package/Config.in
 > @@ -932,7 +932,6 @@ source "package/at/Config.in"
 >  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 >  source "package/bash/Config.in"
 >  source "package/dash/Config.in"
 > -source "package/zsh/Config.in"

You are right, certainly - But I think it is more userfriendly to make
an exception and keep all the shells together.

What do others think?
Thomas Petazzoni Dec. 3, 2013, 8:50 a.m. UTC | #2
Dear Peter Korsgaard,

On Tue, 03 Dec 2013 09:09:36 +0100, Peter Korsgaard wrote:
> >>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
> 
>  > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
>  > ---
>  >  package/Config.in | 4 +++-
>  >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
>  > diff --git a/package/Config.in b/package/Config.in
>  > index a65ceac..e70a58c 100644
>  > --- a/package/Config.in
>  > +++ b/package/Config.in
>  > @@ -932,7 +932,6 @@ source "package/at/Config.in"
>  >  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  >  source "package/bash/Config.in"
>  >  source "package/dash/Config.in"
>  > -source "package/zsh/Config.in"
> 
> You are right, certainly - But I think it is more userfriendly to make
> an exception and keep all the shells together.
> 
> What do others think?

Ideas:

 * Instead of "Shell and utilities", have two menus: "Shell" and
   "Utilities".

 * In the "Shell and utilities" menu, create two sub-sections,
   separated by comments:

comment "Shells"
... some packages ...

comment "Utilities"
... some packages ...

Best regards,

Thomas
Gustavo Zacarias Dec. 3, 2013, 10:23 a.m. UTC | #3
On 12/03/2013 05:50 AM, Thomas Petazzoni wrote:

> Ideas:
> 
>  * Instead of "Shell and utilities", have two menus: "Shell" and
>    "Utilities".
> 
>  * In the "Shell and utilities" menu, create two sub-sections,
>    separated by comments:
> 
> comment "Shells"
> ... some packages ...
> 
> comment "Utilities"
> ... some packages ...

Yes why not?
There aren't enough options to justify sub menus.
While we are on this topic the situation for Graphic libraries and
applications has gone out of control, we really need to split it up a
bit because comments for sections are getting mixed up with comments for
dependencies - it _REALLY_ looks ugly.
Any takers?
Regards.
Peter Korsgaard Dec. 3, 2013, 10:28 a.m. UTC | #4
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 >> You are right, certainly - But I think it is more userfriendly to make
 >> an exception and keep all the shells together.
 >> 
 >> What do others think?

 > Ideas:

 >  * Instead of "Shell and utilities", have two menus: "Shell" and
 >    "Utilities".

 >  * In the "Shell and utilities" menu, create two sub-sections,
 >    separated by comments:

 > comment "Shells"
 > ... some packages ...

 > comment "Utilities"
 > ... some packages ...

Sounds good to me.
Peter Korsgaard Dec. 3, 2013, 10:28 a.m. UTC | #5
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

Hi,

 > While we are on this topic the situation for Graphic libraries and
 > applications has gone out of control, we really need to split it up a
 > bit because comments for sections are getting mixed up with comments for
 > dependencies - it _REALLY_ looks ugly.

Yes, I agree.

 > Any takers?
 > Regards.
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index a65ceac..e70a58c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -932,7 +932,6 @@  source "package/at/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/bash/Config.in"
 source "package/dash/Config.in"
-source "package/zsh/Config.in"
 endif
 source "package/dialog/Config.in"
 source "package/dtach/Config.in"
@@ -949,6 +948,9 @@  source "package/time/Config.in"
 source "package/which/Config.in"
 endif
 source "package/xmlstarlet/Config.in"
+if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
+source "package/zsh/Config.in"
+endif
 endmenu
 
 menu "System tools"