[v2,15/17] pcre: Add host build support

Submitted by Clayton Shotwell on Sept. 11, 2013, 9:59 p.m.

Details

Message ID 1378936777-28308-16-git-send-email-clshotwe@rockwellcollins.com
State Superseded
Headers show

Commit Message

Clayton Shotwell Sept. 11, 2013, 9:59 p.m.
Signed-off-by: Clayton Shotwell <clshotwe@rockwellcollins.com>
---
Changes v1 -> v2:
  - No changes

 package/pcre/pcre.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Thomas Petazzoni Sept. 18, 2013, 5:18 a.m.
Dear Clayton Shotwell,

On Wed, 11 Sep 2013 16:59:35 -0500, Clayton Shotwell wrote:
> 
> Signed-off-by: Clayton Shotwell <clshotwe@rockwellcollins.com>
> ---
> Changes v1 -> v2:
>   - No changes
> 
>  package/pcre/pcre.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/package/pcre/pcre.mk b/package/pcre/pcre.mk
> index bf86a3d..1b59dbc 100644
> --- a/package/pcre/pcre.mk
> +++ b/package/pcre/pcre.mk
> @@ -21,3 +21,4 @@ PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_16),--enable-pcre16,--disable-pcre16)
>  PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_32),--enable-pcre32,--disable-pcre32)
>  
>  $(eval $(autotools-package))
> +$(eval $(host-autotools-package))

This comment applies to patches 15, 16 and 17. Since the host variant
of those packages are used by earlier patches in your series, then
these patches should appear before they are used. Otherwise, your
patch series is not bisectable.

Thanks,

Thomas
Clayton Shotwell Sept. 23, 2013, 9:54 p.m.
Thomas,


Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote on 09/18/2013 
12:18:54 AM:
 
> This comment applies to patches 15, 16 and 17. Since the 
> host variant
> of those packages are used by earlier patches in your series, then
> these patches should appear before they are used. Otherwise, your
> patch series is not bisectable.

I will reorder the patches to they apply in the order of dependence.

Thanks,
Clayton

Clayton Shotwell
Software Engineer
clshotwe@rockwellcollins.com
www.rockwellcollins.com

Patch hide | download patch | download mbox

diff --git a/package/pcre/pcre.mk b/package/pcre/pcre.mk
index bf86a3d..1b59dbc 100644
--- a/package/pcre/pcre.mk
+++ b/package/pcre/pcre.mk
@@ -21,3 +21,4 @@  PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_16),--enable-pcre16,--disable-pcre16)
 PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_32),--enable-pcre32,--disable-pcre32)
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))