Patchwork gpsd: disallow profiling support with Buildroot toolchain

login
register
mail settings
Submitter Simon Dawson
Date July 24, 2012, 8:42 a.m.
Message ID <1343119337-18817-1-git-send-email-spdawson@gmail.com>
Download mbox | patch
Permalink /patch/172807/
State Superseded
Headers show

Comments

Simon Dawson - July 24, 2012, 8:42 a.m.
From: Simon Dawson <spdawson@gmail.com>

The following problem was reported by Thomas Petazzoni.

If BR2_PACKAGE_GPSD_PROFILING is enabled with a Buildroot toolchain, then
gpsd fails to build. See the following for details.

  http://autobuild.buildroot.org/results/be707893f4bf0e7e964d183e4a655c5bb72d1889/build-end.log
  http://autobuild.buildroot.org/results/be707893f4bf0e7e964d183e4a655c5bb72d1889/defconfig.

The issue is that uClibc lacks the necessary infrastructure to support
profiling. This patch disallows selection of the gpsd profiling feature when
the Buildroot toolchain is selected.

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 package/gpsd/Config.in |    4 ++++
 1 file changed, 4 insertions(+)
Thomas Petazzoni - July 24, 2012, 8:51 a.m.
Le Tue, 24 Jul 2012 09:42:17 +0100,
spdawson@gmail.com a écrit :

> +comment "profiling support not available with Buildroot toolchain"
> +	depends on BR2_TOOLCHAIN_BUILDROOT

Is the problem Buildroot-toolchain related, or uClibc related? If it's
uClibc related, it will also show up with uClibc-based external
toolchains and uClibc-based toolchains generated by the Crosstool-NG
backend.

Thomas
Simon Dawson - July 24, 2012, 12:24 p.m.
On 24 July 2012 09:51, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Tue, 24 Jul 2012 09:42:17 +0100,
> spdawson@gmail.com a écrit :
>
>> +comment "profiling support not available with Buildroot toolchain"
>> +     depends on BR2_TOOLCHAIN_BUILDROOT
>
> Is the problem Buildroot-toolchain related, or uClibc related? If it's
> uClibc related, it will also show up with uClibc-based external
> toolchains and uClibc-based toolchains generated by the Crosstool-NG
> backend.

Okay, thanks Thomas. I'll fix and resubmit.

Simon.

Patch

diff --git a/package/gpsd/Config.in b/package/gpsd/Config.in
index 18e21e5..6aa2deb 100644
--- a/package/gpsd/Config.in
+++ b/package/gpsd/Config.in
@@ -31,6 +31,10 @@  config BR2_PACKAGE_GPSD_OLDSTYLE
 
 config BR2_PACKAGE_GPSD_PROFILING
 	bool "profiling support"
+	depends on !BR2_TOOLCHAIN_BUILDROOT
+
+comment "profiling support not available with Buildroot toolchain"
+	depends on BR2_TOOLCHAIN_BUILDROOT
 
 config BR2_PACKAGE_GPSD_NTP_SHM
 	bool "NTP time hinting support"