gdb: fix target gdb build when host-gawk is built before

Submitted by Thomas Petazzoni on May 7, 2012, 1:28 p.m.

Details

Message ID 1336397308-7195-1-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Commit efe0daab8cfef743c282b437c44c35cba7905d44
Headers show

Commit Message

Thomas Petazzoni May 7, 2012, 1:28 p.m.
When the crosstool-ng backend is used, host-gawk is built as a
dependency of the crosstool-ng package, and therefore an host 'gawk'
binary is installed in $(HOST_DIR).

When the target gdb package is also selected, this unfortunately leads
to a build failure, as reported on
http://buildroot.humanoidz.org/results/f19c0499d08212d8b5100fa9434e1197092957db/build-end.log.

The problem is that the ./configure of gdb detects gawk in the PATH,
but at compile time, it gdb fails to find gawk. This is due to the
fact that the gdb compilation process is started without the correct
path. This patch fixes this by passing $(TARGET_MAKE_ENV) in the
environment of the gdb compilation process.

A better fix would be to switch gdb to the AUTOTARGETS infrastructure
in the future.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 toolchain/gdb/gdb.mk |    1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard May 7, 2012, 7:41 p.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> When the crosstool-ng backend is used, host-gawk is built as a
 Thomas> dependency of the crosstool-ng package, and therefore an host 'gawk'
 Thomas> binary is installed in $(HOST_DIR).

 Thomas> When the target gdb package is also selected, this unfortunately leads
 Thomas> to a build failure, as reported on
 Thomas> http://buildroot.humanoidz.org/results/f19c0499d08212d8b5100fa9434e1197092957db/build-end.log.

 Thomas> The problem is that the ./configure of gdb detects gawk in the PATH,
 Thomas> but at compile time, it gdb fails to find gawk. This is due to the

I've dropped 'gdb' from this line. Committed, thanks.

Patch hide | download patch | download mbox

diff --git a/toolchain/gdb/gdb.mk b/toolchain/gdb/gdb.mk
index b5c085b..0b85180 100644
--- a/toolchain/gdb/gdb.mk
+++ b/toolchain/gdb/gdb.mk
@@ -90,6 +90,7 @@  endif
 $(GDB_TARGET_DIR)/gdb/gdb: $(GDB_TARGET_DIR)/.configured
 	# force ELF support since it fails due to BFD linking problems
 	gdb_cv_var_elf=yes \
+	$(TARGET_MAKE_ENV) \
 	$(MAKE) CC="$(TARGET_CC)" MT_CFLAGS="$(TARGET_CFLAGS)" \
 		-C $(GDB_TARGET_DIR)