diff mbox series

[v2,2/2] package/gupnp-dlna: add optional dependency for gobject-introspection

Message ID 20200323175813.3903868-2-aduskett@gmail.com
State Changes Requested
Headers show
Series [v2,1/2] package/vala: install wrapper to vapigen | expand

Commit Message

Adam Duskett March 23, 2020, 5:58 p.m. UTC
From: Adam Duskett <Aduskett@gmail.com>

If gobject-introspection is selected, explicitly set --enable-introspection in
the configure options and add a dependency for both gobject-introspection and
host-vala.

Host-vala is necessary because the introspection includes vala bindings files
with no way to disable them.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
Changes v1 -> v2:
  - Depend on gst plugins (Fabrice Fontaine)
  - Add host-vala to the dependencies.
  - Move the goi check inside of the gst1_plugins_base check.

 package/gupnp-dlna/gupnp-dlna.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/package/gupnp-dlna/gupnp-dlna.mk b/package/gupnp-dlna/gupnp-dlna.mk
index 85d30b7cd2..4eecc0754e 100644
--- a/package/gupnp-dlna/gupnp-dlna.mk
+++ b/package/gupnp-dlna/gupnp-dlna.mk
@@ -16,12 +16,18 @@  GUPNP_DLNA_INSTALL_STAGING = YES
 GUPNP_DLNA_DEPENDENCIES = host-pkgconf libglib2 libxml2
 
 GUPNP_DLNA_CONF_OPTS = \
-	--disable-introspection \
 	--disable-legacy-gstreamer-metadata-backend
 
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE),y)
 GUPNP_DLNA_CONF_OPTS += --enable-gstreamer-metadata-backend
 GUPNP_DLNA_DEPENDENCIES += gstreamer1 gst1-plugins-base
+# vala bindings are created with the .gir files.
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+GUPNP_DLNA_CONF_OPTS += --enable-introspection
+GUPNP_DLNA_DEPENDENCIES += gobject-introspection host-vala
+else
+GUPNP_DLNA_CONF_OPTS += --disable-introspection
+endif
 else
 GUPNP_DLNA_CONF_OPTS += --disable-gstreamer-metadata-backend
 endif