[1/1,B,E,F,OEM-OSP1-B] UBUNTU: SAUCE: platform/x86: dell-uart-backlight: increase retry times
diff mbox series

Message ID 20200212065315.19985-2-acelan.kao@canonical.com
State New
Headers show
  • Sometimes can't adjust brightness on Dell AIO
Related show

Commit Message

AceLan Kao Feb. 12, 2020, 6:53 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1862885

From ODM, scalar takes some time to activate panel during booting up,
it can't respond the UART commands within 1 seconds.
So, we add retry and wait 2 seconds for the response. But sometimes it
still fails to read the response.
During the boot up time, it sometimes takes more than 2 seconds to respond
the first command, so we enlarge the retry timeout from 2 seconds to 5
seconds to make sure we get the first response from scalar.

Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
 drivers/platform/x86/dell-uart-backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/drivers/platform/x86/dell-uart-backlight.c b/drivers/platform/x86/dell-uart-backlight.c
index 76e9a60a9388..bddc4f228bf9 100644
--- a/drivers/platform/x86/dell-uart-backlight.c
+++ b/drivers/platform/x86/dell-uart-backlight.c
@@ -318,7 +318,7 @@  static int dell_uart_get_scalar_status(struct dell_uart_backlight *dell_pdata)
 	struct dell_uart_bl_cmd *bl_cmd = &uart_cmd[DELL_UART_GET_SCALAR];
 	struct uart_8250_port *uart = serial8250_get_port(dell_pdata->line);
 	int rx_len;
-	int status = 0, retry = 20;
+	int status = 0, retry = 50;
 	dell_uart_dump_cmd(__func__, "tx: ", bl_cmd->cmd, bl_cmd->tx_len);