| Message ID | 20200212065315.19985-1-acelan.kao@canonical.com |
|---|---|
| Headers | show |
| Series | Sometimes can't adjust brightness on Dell AIO | expand |
Acked-By: You-Sheng Yang <vicamo.yang@canonical.com> On 2020-02-12 14:53, AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1862885 > > [Impact] > We already added retry on the backlight driver, but the scalar have to > take some time to activate panel during booting up, and 2 seconds seem > doesn't enough. So, it sometimes fails to get the response from scalar. > > [Fix] > Enlarge the retry time from 2 seconds to 5 seconds. > We didn't observe the response time longer than 3 seconds, but to be > more confident, enlarge the value to 5 seconds. > > [Test] > Verified on new Dell AIO platform. > > [Regression Potential] > Low, increase the retry times doesn't hurt anything. > > AceLan Kao (1): > UBUNTU: SAUCE: platform/x86: dell-uart-backlight: increase retry times > > drivers/platform/x86/dell-uart-backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
On Wed, Feb 12, 2020 at 02:53:14PM +0800, AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1862885 > > [Impact] > We already added retry on the backlight driver, but the scalar have to > take some time to activate panel during booting up, and 2 seconds seem > doesn't enough. So, it sometimes fails to get the response from scalar. > > [Fix] > Enlarge the retry time from 2 seconds to 5 seconds. > We didn't observe the response time longer than 3 seconds, but to be > more confident, enlarge the value to 5 seconds. > > [Test] > Verified on new Dell AIO platform. > > [Regression Potential] > Low, increase the retry times doesn't hurt anything. > > AceLan Kao (1): > UBUNTU: SAUCE: platform/x86: dell-uart-backlight: increase retry times > > drivers/platform/x86/dell-uart-backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Anthony Wong <anthony.wong@canonical.com>
On 12.2.2020 8.53, AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1862885 > > [Impact] > We already added retry on the backlight driver, but the scalar have to > take some time to activate panel during booting up, and 2 seconds seem > doesn't enough. So, it sometimes fails to get the response from scalar. > > [Fix] > Enlarge the retry time from 2 seconds to 5 seconds. > We didn't observe the response time longer than 3 seconds, but to be > more confident, enlarge the value to 5 seconds. > > [Test] > Verified on new Dell AIO platform. > > [Regression Potential] > Low, increase the retry times doesn't hurt anything. > > AceLan Kao (1): > UBUNTU: SAUCE: platform/x86: dell-uart-backlight: increase retry times > > drivers/platform/x86/dell-uart-backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > applied to osp1 oem-next, thanks
On 2020-02-12 14:53:14 , AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1862885 > > [Impact] > We already added retry on the backlight driver, but the scalar have to > take some time to activate panel during booting up, and 2 seconds seem > doesn't enough. So, it sometimes fails to get the response from scalar. > > [Fix] > Enlarge the retry time from 2 seconds to 5 seconds. > We didn't observe the response time longer than 3 seconds, but to be > more confident, enlarge the value to 5 seconds. > > [Test] > Verified on new Dell AIO platform. > > [Regression Potential] > Low, increase the retry times doesn't hurt anything. > > AceLan Kao (1): > UBUNTU: SAUCE: platform/x86: dell-uart-backlight: increase retry times > > drivers/platform/x86/dell-uart-backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On Wed, Feb 12, 2020 at 02:53:14PM +0800, AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1862885 > > [Impact] > We already added retry on the backlight driver, but the scalar have to > take some time to activate panel during booting up, and 2 seconds seem > doesn't enough. So, it sometimes fails to get the response from scalar. > > [Fix] > Enlarge the retry time from 2 seconds to 5 seconds. > We didn't observe the response time longer than 3 seconds, but to be > more confident, enlarge the value to 5 seconds. > > [Test] > Verified on new Dell AIO platform. > > [Regression Potential] > Low, increase the retry times doesn't hurt anything. Applied to focal/master-next and unstable/master, thanks!