| Message ID | 20190816124529.1178-2-sr@denx.de |
|---|---|
| State | Accepted |
| Commit | d117f917bfd2ccf4eaf90bddfa256501a554b1a4 |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [U-Boot,1/2] x86: Remove x86 specific GD flags as they are not referenced at all | expand |
On Fri, Aug 16, 2019 at 8:45 PM Stefan Roese <sr@denx.de> wrote: > > With the removal of the x86 specific GD flags, there are no arch- > specific GD flags any more. Let's remove the comment about reserving the > upper 16 bits for arch-specific flags in the common header. This gives > us more flexibility with the usage of the GD flags. > > As a matter of fact, we are already using more than 16 bits for common > GD flags (with the addition of GD_FLG_WDT_READY). > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Bin Meng <bmeng.cn@gmail.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Rini <trini@konsulko.com> > Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > --- > include/asm-generic/global_data.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Stefan Roese <sr@denx.de> schrieb am Fr., 16. Aug. 2019, 14:45: > With the removal of the x86 specific GD flags, there are no arch- > specific GD flags any more. Let's remove the comment about reserving the > upper 16 bits for arch-specific flags in the common header. This gives > us more flexibility with the usage of the GD flags. > > As a matter of fact, we are already using more than 16 bits for common > GD flags (with the addition of GD_FLG_WDT_READY). > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Bin Meng <bmeng.cn@gmail.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Rini <trini@konsulko.com> > Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> --- > include/asm-generic/global_data.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/asm-generic/global_data.h > b/include/asm-generic/global_data.h > index 5372d5d8cd..7587ba2ee5 100644 > --- a/include/asm-generic/global_data.h > +++ b/include/asm-generic/global_data.h > @@ -150,7 +150,7 @@ typedef struct global_data { > #endif > > /* > - * Global Data Flags - the top 16 bits are reserved for arch-specific > flags > + * Global Data Flags > */ > #define GD_FLG_RELOC 0x00001 /* Code was relocated to RAM > */ > #define GD_FLG_DEVINIT 0x00002 /* Devices have been initialized > */ > -- > 2.22.1 > >
On Fri, 16 Aug 2019 at 10:05, Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> wrote: > > > > Stefan Roese <sr@denx.de> schrieb am Fr., 16. Aug. 2019, 14:45: >> >> With the removal of the x86 specific GD flags, there are no arch- >> specific GD flags any more. Let's remove the comment about reserving the >> upper 16 bits for arch-specific flags in the common header. This gives >> us more flexibility with the usage of the GD flags. >> >> As a matter of fact, we are already using more than 16 bits for common >> GD flags (with the addition of GD_FLG_WDT_READY). >> >> Signed-off-by: Stefan Roese <sr@denx.de> >> Cc: Bin Meng <bmeng.cn@gmail.com> >> Cc: Simon Glass <sjg@chromium.org> >> Cc: Tom Rini <trini@konsulko.com> >> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > > > Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org>
On Fri, Aug 16, 2019 at 11:59 PM Simon Glass <sjg@chromium.org> wrote: > > On Fri, 16 Aug 2019 at 10:05, Simon Goldschmidt > <simon.k.r.goldschmidt@gmail.com> wrote: > > > > > > > > Stefan Roese <sr@denx.de> schrieb am Fr., 16. Aug. 2019, 14:45: > >> > >> With the removal of the x86 specific GD flags, there are no arch- > >> specific GD flags any more. Let's remove the comment about reserving the > >> upper 16 bits for arch-specific flags in the common header. This gives > >> us more flexibility with the usage of the GD flags. > >> > >> As a matter of fact, we are already using more than 16 bits for common > >> GD flags (with the addition of GD_FLG_WDT_READY). > >> > >> Signed-off-by: Stefan Roese <sr@denx.de> > >> Cc: Bin Meng <bmeng.cn@gmail.com> > >> Cc: Simon Glass <sjg@chromium.org> > >> Cc: Tom Rini <trini@konsulko.com> > >> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > > > > > > Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > > Reviewed-by: Simon Glass <sjg@chromium.org> applied to u-boot-x86, thanks!
diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h index 5372d5d8cd..7587ba2ee5 100644 --- a/include/asm-generic/global_data.h +++ b/include/asm-generic/global_data.h @@ -150,7 +150,7 @@ typedef struct global_data { #endif /* - * Global Data Flags - the top 16 bits are reserved for arch-specific flags + * Global Data Flags */ #define GD_FLG_RELOC 0x00001 /* Code was relocated to RAM */ #define GD_FLG_DEVINIT 0x00002 /* Devices have been initialized */
With the removal of the x86 specific GD flags, there are no arch- specific GD flags any more. Let's remove the comment about reserving the upper 16 bits for arch-specific flags in the common header. This gives us more flexibility with the usage of the GD flags. As a matter of fact, we are already using more than 16 bits for common GD flags (with the addition of GD_FLG_WDT_READY). Signed-off-by: Stefan Roese <sr@denx.de> Cc: Bin Meng <bmeng.cn@gmail.com> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@konsulko.com> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> --- include/asm-generic/global_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)