| Message ID | 1258927311-4340-8-git-send-email-albert_herranz@yahoo.es (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sunday 22 November 2009, Albert Herranz wrote: > config NOT_COHERENT_CACHE > bool > - depends on 4xx || 8xx || E200 || PPC_MPC512x > + depends on 4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON > default y > > config CHECK_CACHE_COHERENCY > diff --git a/arch/powerpc/platforms/embedded6xx/Kconfig b/arch/powerpc/platforms/embedded6xx/Kconfig > index 97a2dbc..31487e4 100644 > --- a/arch/powerpc/platforms/embedded6xx/Kconfig > +++ b/arch/powerpc/platforms/embedded6xx/Kconfig > @@ -93,4 +93,5 @@ config MPC10X_STORE_GATHERING > > config GAMECUBE_COMMON > bool > + select NOT_COHERENT_CACHE One of the two (depends and select) is enough. I'd just drop the 'select' line here. Arnd <><
Arnd Bergmann wrote: > On Sunday 22 November 2009, Albert Herranz wrote: >> config NOT_COHERENT_CACHE >> bool >> - depends on 4xx || 8xx || E200 || PPC_MPC512x >> + depends on 4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON >> default y >> >> config CHECK_CACHE_COHERENCY >> diff --git a/arch/powerpc/platforms/embedded6xx/Kconfig b/arch/powerpc/platforms/embedded6xx/Kconfig >> index 97a2dbc..31487e4 100644 >> --- a/arch/powerpc/platforms/embedded6xx/Kconfig >> +++ b/arch/powerpc/platforms/embedded6xx/Kconfig >> @@ -93,4 +93,5 @@ config MPC10X_STORE_GATHERING >> >> config GAMECUBE_COMMON >> bool >> + select NOT_COHERENT_CACHE > > One of the two (depends and select) is enough. I'd just drop the 'select' > line here. > > Arnd <>< > Thanks, I'll fix that. Cheers, Albert
On Sun, 2009-11-22 at 23:01 +0100, Albert Herranz wrote: > The processors bundled in the Nintendo GameCube and Wii video game consoles > require explicit cache handling when DMA engines are used. That reminds me we really need to make that a runtime option some day... Cheers, Ben. > Signed-off-by: Albert Herranz <albert_herranz@yahoo.es> > --- > arch/powerpc/platforms/Kconfig.cputype | 2 +- > arch/powerpc/platforms/embedded6xx/Kconfig | 1 + > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype > index e382cae..80d934b 100644 > --- a/arch/powerpc/platforms/Kconfig.cputype > +++ b/arch/powerpc/platforms/Kconfig.cputype > @@ -312,7 +312,7 @@ config NR_CPUS > > config NOT_COHERENT_CACHE > bool > - depends on 4xx || 8xx || E200 || PPC_MPC512x > + depends on 4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON > default y > > config CHECK_CACHE_COHERENCY > diff --git a/arch/powerpc/platforms/embedded6xx/Kconfig b/arch/powerpc/platforms/embedded6xx/Kconfig > index 97a2dbc..31487e4 100644 > --- a/arch/powerpc/platforms/embedded6xx/Kconfig > +++ b/arch/powerpc/platforms/embedded6xx/Kconfig > @@ -93,4 +93,5 @@ config MPC10X_STORE_GATHERING > > config GAMECUBE_COMMON > bool > + select NOT_COHERENT_CACHE >
diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index e382cae..80d934b 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -312,7 +312,7 @@ config NR_CPUS config NOT_COHERENT_CACHE bool - depends on 4xx || 8xx || E200 || PPC_MPC512x + depends on 4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON default y config CHECK_CACHE_COHERENCY diff --git a/arch/powerpc/platforms/embedded6xx/Kconfig b/arch/powerpc/platforms/embedded6xx/Kconfig index 97a2dbc..31487e4 100644 --- a/arch/powerpc/platforms/embedded6xx/Kconfig +++ b/arch/powerpc/platforms/embedded6xx/Kconfig @@ -93,4 +93,5 @@ config MPC10X_STORE_GATHERING config GAMECUBE_COMMON bool + select NOT_COHERENT_CACHE
The processors bundled in the Nintendo GameCube and Wii video game consoles require explicit cache handling when DMA engines are used. Signed-off-by: Albert Herranz <albert_herranz@yahoo.es> --- arch/powerpc/platforms/Kconfig.cputype | 2 +- arch/powerpc/platforms/embedded6xx/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletions(-)