| Message ID | 1398857290-22028-4-git-send-email-p.marczak@samsung.com |
|---|---|
| State | Accepted |
| Delegated to: | Minkyu Kang |
| Headers | show |
On Wed, 2014-04-30 at 13:28 +0200, Przemyslaw Marczak wrote: > > Increase menu loop delay to 200 ms helps choose the right > menu option by user. Before this, each time key was pressed > the current menu option was changed few times. > Now it changes only once and also changes few times if key > is pressed for a longer time. Since this description better reflects the motivation of the change, and because there appears to be no need to actually de-bounce the keys, I think this patch is good. virtually yours Gerhard Sittig
On 05/05/2014 03:35 PM, Gerhard Sittig wrote: > On Wed, 2014-04-30 at 13:28 +0200, Przemyslaw Marczak wrote: >> >> Increase menu loop delay to 200 ms helps choose the right >> menu option by user. Before this, each time key was pressed >> the current menu option was changed few times. >> Now it changes only once and also changes few times if key >> is pressed for a longer time. > > Since this description better reflects the motivation of the > change, and because there appears to be no need to actually > de-bounce the keys, I think this patch is good. > > > virtually yours > Gerhard Sittig > Thanks:)
On 30/04/14 20:28, Przemyslaw Marczak wrote: > Increase menu loop delay to 200 ms helps choose the right > menu option by user. Before this, each time key was pressed > the current menu option was changed few times. > Now it changes only once and also changes few times if key > is pressed for a longer time. > > Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> > Cc: Minkyu Kang <mk7.kang@samsung.com> > > --- > Changes v2: > - new commit > > Changes v3: > - correct commit message > > Changes v4: > - none > > Changes v5: > - move mdelay() from check_keys() to menu loop > - update commit msg > > --- > board/samsung/common/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > applied to u-boot-samsung. Thanks, Minkyu Kang.
diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c index 65b5c30..2ea275e 100644 --- a/board/samsung/common/misc.c +++ b/board/samsung/common/misc.c @@ -285,7 +285,7 @@ static void download_menu(void) display_download_menu(mode); last_mode = mode; - mdelay(100); + mdelay(200); key = check_keys(); switch (key) {
Increase menu loop delay to 200 ms helps choose the right menu option by user. Before this, each time key was pressed the current menu option was changed few times. Now it changes only once and also changes few times if key is pressed for a longer time. Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> Cc: Minkyu Kang <mk7.kang@samsung.com> --- Changes v2: - new commit Changes v3: - correct commit message Changes v4: - none Changes v5: - move mdelay() from check_keys() to menu loop - update commit msg --- board/samsung/common/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)