| Message ID | 1398716258-8420-4-git-send-email-tharvey@gateworks.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi Tim, On 04/28/2014 01:17 PM, Tim Harvey wrote: > Add a common header which can hopefully be shared amon imx6 SPL users > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > --- > v2: > - adjust CONFIG_SPL_TEXT_BASE, CONFIG_SPL_STACK and CONFIG_SPL_MAX_SIZE > to accomodate the IMX6SOLO/DUALLITE which have half the iRAM of the > IMX6DUAL/IMX6QUAD > --- > include/configs/imx6_spl.h | 71 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 include/configs/imx6_spl.h > > diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h > new file mode 100644 > index 0000000..20078cc > --- /dev/null > +++ b/include/configs/imx6_spl.h > @@ -0,0 +1,71 @@ > +/* > + * Copyright (C) 2014 Gateworks Corporation > + * Author: Tim Harvey <tharvey@gateworks.com> > + * > + * SPDX-License-Identifier: GPL-2.0+ > + */ > +#ifndef __IMX6_SPL_CONFIG_H > +#define __IMX6_SPL_CONFIG_H > + > +#ifdef CONFIG_SPL > + > +#define CONFIG_SPL_FRAMEWORK > + > +/* > + * see Figure 8-3 in IMX6DQ/IMX6SDL Reference manuals: s/IMX6SLD/IMX6SDL/g > + * - IMX6 OCRAM (IRAM) is from 0x00907000 to 0x0091FFFF (IMX6SLD) > + * - IMX6DQ has 2x IRAM of IMX6SLD but we intend to support IMX6SLD as well ... I was about to complain about the use of IMX6SLD (the nomenclature i.MX6DL/S seems more common), but the RM __is__ named SDL... Regards, Eric
Hi, On 04/29/14 07:14, Eric Nelson wrote: > Hi Tim, > > On 04/28/2014 01:17 PM, Tim Harvey wrote: >> Add a common header which can hopefully be shared amon imx6 SPL users >> >> Signed-off-by: Tim Harvey <tharvey@gateworks.com> >> --- >> v2: >> - adjust CONFIG_SPL_TEXT_BASE, CONFIG_SPL_STACK and CONFIG_SPL_MAX_SIZE >> to accomodate the IMX6SOLO/DUALLITE which have half the iRAM of the >> IMX6DUAL/IMX6QUAD >> --- >> include/configs/imx6_spl.h | 71 ++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 71 insertions(+) >> create mode 100644 include/configs/imx6_spl.h >> >> diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h >> new file mode 100644 >> index 0000000..20078cc >> --- /dev/null >> +++ b/include/configs/imx6_spl.h >> @@ -0,0 +1,71 @@ >> +/* >> + * Copyright (C) 2014 Gateworks Corporation >> + * Author: Tim Harvey <tharvey@gateworks.com> >> + * >> + * SPDX-License-Identifier: GPL-2.0+ >> + */ >> +#ifndef __IMX6_SPL_CONFIG_H >> +#define __IMX6_SPL_CONFIG_H >> + >> +#ifdef CONFIG_SPL >> + >> +#define CONFIG_SPL_FRAMEWORK >> + >> +/* >> + * see Figure 8-3 in IMX6DQ/IMX6SDL Reference manuals: > > s/IMX6SLD/IMX6SDL/g > >> + * - IMX6 OCRAM (IRAM) is from 0x00907000 to 0x0091FFFF (IMX6SLD) >> + * - IMX6DQ has 2x IRAM of IMX6SLD but we intend to support IMX6SLD as well > > ... I was about to complain about the use of IMX6SLD (the nomenclature > i.MX6DL/S seems more common), but the RM __is__ named SDL... SDL stands for Solo/Dual Lite, so SLD is plain wrong... (Solo Lite and Dual are so different...)
On Mon, Apr 28, 2014 at 11:37 PM, Igor Grinberg <grinberg@compulab.co.il> wrote: > Hi, > > On 04/29/14 07:14, Eric Nelson wrote: >> Hi Tim, >> >> On 04/28/2014 01:17 PM, Tim Harvey wrote: >>> Add a common header which can hopefully be shared amon imx6 SPL users >>> >>> Signed-off-by: Tim Harvey <tharvey@gateworks.com> >>> --- >>> v2: >>> - adjust CONFIG_SPL_TEXT_BASE, CONFIG_SPL_STACK and CONFIG_SPL_MAX_SIZE >>> to accomodate the IMX6SOLO/DUALLITE which have half the iRAM of the >>> IMX6DUAL/IMX6QUAD >>> --- >>> include/configs/imx6_spl.h | 71 ++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 71 insertions(+) >>> create mode 100644 include/configs/imx6_spl.h >>> >>> diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h >>> new file mode 100644 >>> index 0000000..20078cc >>> --- /dev/null >>> +++ b/include/configs/imx6_spl.h >>> @@ -0,0 +1,71 @@ >>> +/* >>> + * Copyright (C) 2014 Gateworks Corporation >>> + * Author: Tim Harvey <tharvey@gateworks.com> >>> + * >>> + * SPDX-License-Identifier: GPL-2.0+ >>> + */ >>> +#ifndef __IMX6_SPL_CONFIG_H >>> +#define __IMX6_SPL_CONFIG_H >>> + >>> +#ifdef CONFIG_SPL >>> + >>> +#define CONFIG_SPL_FRAMEWORK >>> + >>> +/* >>> + * see Figure 8-3 in IMX6DQ/IMX6SDL Reference manuals: >> >> s/IMX6SLD/IMX6SDL/g >> >>> + * - IMX6 OCRAM (IRAM) is from 0x00907000 to 0x0091FFFF (IMX6SLD) >>> + * - IMX6DQ has 2x IRAM of IMX6SLD but we intend to support IMX6SLD as well >> >> ... I was about to complain about the use of IMX6SLD (the nomenclature >> i.MX6DL/S seems more common), but the RM __is__ named SDL... > > SDL stands for Solo/Dual Lite, so SLD is plain wrong... > (Solo Lite and Dual are so different...) > > > -- > Regards, > Igor. Igor / Eric, Yes this was definitely a typo - no idea how I kept making the same typo over and over again... late nights! I'll fix this for the next revision and refer to the CPU types as 'IMX6DQ' and 'IMX6SDL'. Please let me know if there is anything else you see that needs to be discussed. Tim
Hi Tim, On 28/04/2014 22:17, Tim Harvey wrote: > Add a common header which can hopefully be shared amon imx6 SPL users > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > --- > v2: > - adjust CONFIG_SPL_TEXT_BASE, CONFIG_SPL_STACK and CONFIG_SPL_MAX_SIZE > to accomodate the IMX6SOLO/DUALLITE which have half the iRAM of the > IMX6DUAL/IMX6QUAD > --- > include/configs/imx6_spl.h | 71 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 include/configs/imx6_spl.h > > diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h > new file mode 100644 > index 0000000..20078cc > --- /dev/null > +++ b/include/configs/imx6_spl.h > @@ -0,0 +1,71 @@ > +/* > + * Copyright (C) 2014 Gateworks Corporation > + * Author: Tim Harvey <tharvey@gateworks.com> > + * > + * SPDX-License-Identifier: GPL-2.0+ > + */ > +#ifndef __IMX6_SPL_CONFIG_H > +#define __IMX6_SPL_CONFIG_H > + > +#ifdef CONFIG_SPL > + > +#define CONFIG_SPL_FRAMEWORK > + > +/* > + * see Figure 8-3 in IMX6DQ/IMX6SDL Reference manuals: > + * - IMX6 OCRAM (IRAM) is from 0x00907000 to 0x0091FFFF (IMX6SLD) > + * - IMX6DQ has 2x IRAM of IMX6SLD but we intend to support IMX6SLD as well > + * - BOOT ROM stack is at 0x0091FFB8 > + * - if icache/dcache is enabled (eFuse/strapping controlled) then the > + * IMX BOOT ROM will setup MMU table at 0x00918000, therefore we need to > + * fit between 0x00907000 and 0x00918000. > + * - Additionally the BOOT ROM loads what they consider the firmware image > + * which consists of a 4K header in front of us that contains the IVT, DCD > + * and some padding thus 'our' max size is really 0x00908000 - 0x00918000 > + * or 64KB > + */ > +#define CONFIG_SPL_LDSCRIPT "arch/arm/cpu/armv7/omap-common/u-boot-spl.lds" > +#define CONFIG_SPL_TEXT_BASE 0x00908000 > +#define CONFIG_SPL_MAX_SIZE (64 * 1024) > +#define CONFIG_SPL_START_S_PATH "arch/arm/cpu/armv7" > +#define CONFIG_SPL_STACK 0x0091FFB8 > +#define CONFIG_SPL_LIBCOMMON_SUPPORT > +#define CONFIG_SPL_LIBGENERIC_SUPPORT > +#define CONFIG_SPL_SERIAL_SUPPORT > +#define CONFIG_SPL_I2C_SUPPORT > +#define CONFIG_SPL_GPIO_SUPPORT > + > +/* NAND support */ > +#if defined(CONFIG_SPL_NAND_SUPPORT) > +#define CONFIG_SPL_NAND_MXS > +#define CONFIG_SPL_DMA_SUPPORT > +#endif > + > +/* MMC support */ > +#if defined(CONFIG_SPL_MMC_SUPPORT) > +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 138 /* offset 69KB */ > +#define CONFIG_SYS_U_BOOT_MAX_SIZE_SECTORS 800 /* 400 KB */ > +#define CONFIG_SYS_MMC_SD_FAT_BOOT_PARTITION 1 > +#define CONFIG_SYS_MONITOR_LEN (CONFIG_SYS_U_BOOT_MAX_SIZE_SECTORS/2*1024) > +#endif > + > +/* SATA support */ > +#if defined(CONFIG_SPL_SATA_SUPPORT) > +#define CONFIG_SPL_SATA_BOOT_DEVICE 0 > +#define CONFIG_SYS_SATA_FAT_BOOT_PARTITION 1 > +#endif > + > +/* Define the payload for FAT/EXT support */ > +#if defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT) > +#define CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME "u-boot.img" > +#define CONFIG_SPL_LIBDISK_SUPPORT > +#endif > + > +#define CONFIG_SPL_BSS_START_ADDR 0x18200000 > +#define CONFIG_SPL_BSS_MAX_SIZE 0x100000 /* 1 MB */ > +#define CONFIG_SYS_SPL_MALLOC_START 0x18300000 > +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x3200000 /* 50 MB */ > +#define CONFIG_SYS_TEXT_BASE 0x17800000 > +#endif > + > +#endif > I generally agree with the idea having a common setup - this simplifies porting of new boards to SPL ! Apart the small typos found by Eric/Igor: Acked-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic
On 28/04/14 23:17, Tim Harvey wrote: > Add a common header which can hopefully be shared amon imx6 SPL users > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > --- > v2: > - adjust CONFIG_SPL_TEXT_BASE, CONFIG_SPL_STACK and CONFIG_SPL_MAX_SIZE > to accomodate the IMX6SOLO/DUALLITE which have half the iRAM of the > IMX6DUAL/IMX6QUAD Aside from the typos, Acked-by: Nikita Kiryanov <nikita@compulab.co.il> -- Regards, Nikita Kiryanov
diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h new file mode 100644 index 0000000..20078cc --- /dev/null +++ b/include/configs/imx6_spl.h @@ -0,0 +1,71 @@ +/* + * Copyright (C) 2014 Gateworks Corporation + * Author: Tim Harvey <tharvey@gateworks.com> + * + * SPDX-License-Identifier: GPL-2.0+ + */ +#ifndef __IMX6_SPL_CONFIG_H +#define __IMX6_SPL_CONFIG_H + +#ifdef CONFIG_SPL + +#define CONFIG_SPL_FRAMEWORK + +/* + * see Figure 8-3 in IMX6DQ/IMX6SDL Reference manuals: + * - IMX6 OCRAM (IRAM) is from 0x00907000 to 0x0091FFFF (IMX6SLD) + * - IMX6DQ has 2x IRAM of IMX6SLD but we intend to support IMX6SLD as well + * - BOOT ROM stack is at 0x0091FFB8 + * - if icache/dcache is enabled (eFuse/strapping controlled) then the + * IMX BOOT ROM will setup MMU table at 0x00918000, therefore we need to + * fit between 0x00907000 and 0x00918000. + * - Additionally the BOOT ROM loads what they consider the firmware image + * which consists of a 4K header in front of us that contains the IVT, DCD + * and some padding thus 'our' max size is really 0x00908000 - 0x00918000 + * or 64KB + */ +#define CONFIG_SPL_LDSCRIPT "arch/arm/cpu/armv7/omap-common/u-boot-spl.lds" +#define CONFIG_SPL_TEXT_BASE 0x00908000 +#define CONFIG_SPL_MAX_SIZE (64 * 1024) +#define CONFIG_SPL_START_S_PATH "arch/arm/cpu/armv7" +#define CONFIG_SPL_STACK 0x0091FFB8 +#define CONFIG_SPL_LIBCOMMON_SUPPORT +#define CONFIG_SPL_LIBGENERIC_SUPPORT +#define CONFIG_SPL_SERIAL_SUPPORT +#define CONFIG_SPL_I2C_SUPPORT +#define CONFIG_SPL_GPIO_SUPPORT + +/* NAND support */ +#if defined(CONFIG_SPL_NAND_SUPPORT) +#define CONFIG_SPL_NAND_MXS +#define CONFIG_SPL_DMA_SUPPORT +#endif + +/* MMC support */ +#if defined(CONFIG_SPL_MMC_SUPPORT) +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 138 /* offset 69KB */ +#define CONFIG_SYS_U_BOOT_MAX_SIZE_SECTORS 800 /* 400 KB */ +#define CONFIG_SYS_MMC_SD_FAT_BOOT_PARTITION 1 +#define CONFIG_SYS_MONITOR_LEN (CONFIG_SYS_U_BOOT_MAX_SIZE_SECTORS/2*1024) +#endif + +/* SATA support */ +#if defined(CONFIG_SPL_SATA_SUPPORT) +#define CONFIG_SPL_SATA_BOOT_DEVICE 0 +#define CONFIG_SYS_SATA_FAT_BOOT_PARTITION 1 +#endif + +/* Define the payload for FAT/EXT support */ +#if defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT) +#define CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME "u-boot.img" +#define CONFIG_SPL_LIBDISK_SUPPORT +#endif + +#define CONFIG_SPL_BSS_START_ADDR 0x18200000 +#define CONFIG_SPL_BSS_MAX_SIZE 0x100000 /* 1 MB */ +#define CONFIG_SYS_SPL_MALLOC_START 0x18300000 +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x3200000 /* 50 MB */ +#define CONFIG_SYS_TEXT_BASE 0x17800000 +#endif + +#endif
Add a common header which can hopefully be shared amon imx6 SPL users Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- v2: - adjust CONFIG_SPL_TEXT_BASE, CONFIG_SPL_STACK and CONFIG_SPL_MAX_SIZE to accomodate the IMX6SOLO/DUALLITE which have half the iRAM of the IMX6DUAL/IMX6QUAD --- include/configs/imx6_spl.h | 71 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 include/configs/imx6_spl.h