| Message ID | 4A3B3D90.5030100@arvoo.nl (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Kumar Gala |
| Headers | show |
On Jun 19, 2009, at 2:26 AM, Rini van Zetten wrote: > This patch adds the possibility to have a spi device without a cs. > > For example, the dts file should look something like this: > > spi-controller { > gpios = <&pio1 1 0 /* cs0 */ > 0 /* cs1, no GPIO */ > &pio2 2 0>; /* cs2 */ > > Signed-off-by: Rini van Zetten <rini@arvoo.nl> > --- > Changes : > patch against 2.6.30-rc8-mm1 > style updates > compiler warning fix > comment : > This feature is needed on our home made board to program an onboard > fpga. > The fpga needs some special pin toggling to put it in programming > mode. > That's why we want to skip the usual gpio cs and do the pin toggling > in our driver > Which FSL chip are you using? - k
> > On Jun 19, 2009, at 2:26 AM, Rini van Zetten wrote: > >> This patch adds the possibility to have a spi device without a cs. >> >> For example, the dts file should look something like this: >> >> spi-controller { >> gpios = <&pio1 1 0 /* cs0 */ >> 0 /* cs1, no GPIO */ >> &pio2 2 0>; /* cs2 */ >> >> Signed-off-by: Rini van Zetten <rini@arvoo.nl> >> --- >> Changes : >> patch against 2.6.30-rc8-mm1 >> style updates >> compiler warning fix >> comment : >> This feature is needed on our home made board to program an >> onboard fpga. >> The fpga needs some special pin toggling to put it in programming >> mode. >> That's why we want to skip the usual gpio cs and do the pin toggling >> in our driver >> > > Which FSL chip are you using? We use the MPC8377E Rini > > - k > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
On Fri, Jun 19, 2009 at 09:26:08AM +0200, Rini van Zetten wrote: > This patch adds the possibility to have a spi device without a cs. > > For example, the dts file should look something like this: > > spi-controller { > gpios = <&pio1 1 0 /* cs0 */ > 0 /* cs1, no GPIO */ > &pio2 2 0>; /* cs2 */ > > Signed-off-by: Rini van Zetten <rini@arvoo.nl> > --- > Changes : > patch against 2.6.30-rc8-mm1 > style updates > compiler warning fix > comment : > This feature is needed on our home made board to program an onboard fpga. > The fpga needs some special pin toggling to put it in programming mode. > That's why we want to skip the usual gpio cs and do the pin toggling > in our driver Cool, thanks for the explanation. You may want to put it into the commit message. [...] > + ret = gpio_direction_output(pinfo->gpios[i], > + pinfo->alow_flags[i]); > + if (ret) { > + dev_err(dev, "can't set output direction for" > + "gpio #%d: %d\n", > + i, ret); There is no space between 'for' and 'gpio' words. (also the whole dev_err() may fit into two lines, no need to split it into three lines). Otherwise looks great. On the next resend feel free to add my Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com> Thanks,
diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c index 0fd0ec4..3a367ce 100644 --- a/drivers/spi/spi_mpc8xxx.c +++ b/drivers/spi/spi_mpc8xxx.c @@ -666,9 +666,12 @@ static void mpc8xxx_spi_cs_control(struct spi_device *spi, bool on) struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(dev->platform_data); u16 cs = spi->chip_select; int gpio = pinfo->gpios[cs]; - bool alow = pinfo->alow_flags[cs]; - gpio_set_value(gpio, on ^ alow); + if (gpio != -EEXIST) { + bool alow = pinfo->alow_flags[cs]; + + gpio_set_value(gpio, on ^ alow); + } } static int of_mpc8xxx_spi_get_chipselects(struct device *dev) @@ -707,27 +710,31 @@ static int of_mpc8xxx_spi_get_chipselects(struct device *dev) enum of_gpio_flags flags; gpio = of_get_gpio_flags(np, i, &flags); - if (!gpio_is_valid(gpio)) { + if (gpio_is_valid(gpio)) { + ret = gpio_request(gpio, dev_name(dev)); + if (ret) { + dev_err(dev, "can't request gpio #%d: %d\n", + i, ret); + goto err_loop; + } + + pinfo->gpios[i] = gpio; + pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW; + + ret = gpio_direction_output(pinfo->gpios[i], + pinfo->alow_flags[i]); + if (ret) { + dev_err(dev, "can't set output direction for" + "gpio #%d: %d\n", + i, ret); + goto err_loop; + } + } else if (gpio == -EEXIST) { + pinfo->gpios[i] = -EEXIST; + } else { dev_err(dev, "invalid gpio #%d: %d\n", i, gpio); goto err_loop; } - - ret = gpio_request(gpio, dev_name(dev)); - if (ret) { - dev_err(dev, "can't request gpio #%d: %d\n", i, ret); - goto err_loop; - } - - pinfo->gpios[i] = gpio; - pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW; - - ret = gpio_direction_output(pinfo->gpios[i], - pinfo->alow_flags[i]); - if (ret) { - dev_err(dev, "can't set output direction for gpio " - "#%d: %d\n", i, ret); - goto err_loop; - } } pdata->max_chipselect = ngpios;
This patch adds the possibility to have a spi device without a cs. For example, the dts file should look something like this: spi-controller { gpios = <&pio1 1 0 /* cs0 */ 0 /* cs1, no GPIO */ &pio2 2 0>; /* cs2 */ Signed-off-by: Rini van Zetten <rini@arvoo.nl> --- Changes : patch against 2.6.30-rc8-mm1 style updates compiler warning fix comment : This feature is needed on our home made board to program an onboard fpga. The fpga needs some special pin toggling to put it in programming mode. That's why we want to skip the usual gpio cs and do the pin toggling in our driver