| Message ID | 1378144503-15808-4-git-send-email-rth@twiddle.net |
|---|---|
| State | New |
| Headers | show |
On 02.09.2013 19:54, Richard Henderson wrote: > Signed-off-by: Richard Henderson <rth@twiddle.net> > --- > tcg/aarch64/tcg-target.c | 20 +++++++------------- > 1 file changed, 7 insertions(+), 13 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index bde4c72..79a447d 100644 > --- a/tcg/aarch64/tcg-target.c > +++ b/tcg/aarch64/tcg-target.c > @@ -1162,18 +1162,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, > args[0], args[1], args[2]); > break; > > - case INDEX_op_mov_i64: > - case INDEX_op_mov_i32: > - tcg_out_movr(s, ext, args[0], args[1]); > - break; > - > - case INDEX_op_movi_i64: > - tcg_out_movi(s, TCG_TYPE_I64, args[0], args[1]); > - break; > - case INDEX_op_movi_i32: > - tcg_out_movi(s, TCG_TYPE_I32, args[0], args[1]); > - break; > - > case INDEX_op_add_i64: > case INDEX_op_add_i32: > tcg_out_arith(s, ARITH_ADD, ext, args[0], args[1], args[2], 0); > @@ -1337,8 +1325,14 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, > tcg_out_movr(s, 0, args[0], args[1]); > break; > > + case INDEX_op_mov_i64: > + case INDEX_op_mov_i32: > + case INDEX_op_movi_i64: > + case INDEX_op_movi_i32: > + /* Always implemented with tcg_out_mov/i, never with tcg_out_op. */ > default: > - tcg_abort(); /* opcode not implemented */ > + /* Opcode not implemented. */ > + tcg_abort(); > } > } > Ok
On 09/12/2013 01:30 AM, Claudio Fontana wrote: >> + case INDEX_op_mov_i64: >> + case INDEX_op_mov_i32: >> + case INDEX_op_movi_i64: >> + case INDEX_op_movi_i32: >> + /* Always implemented with tcg_out_mov/i, never with tcg_out_op. */ >> default: >> - tcg_abort(); /* opcode not implemented */ >> + /* Opcode not implemented. */ >> + tcg_abort(); >> } >> } >> > > Ok Sadly, "Ok" is neither Reviewed-by or Signed-off-by. r~
On 12.09.2013 16:02, Richard Henderson wrote: > On 09/12/2013 01:30 AM, Claudio Fontana wrote: >>> + case INDEX_op_mov_i64: >>> + case INDEX_op_mov_i32: >>> + case INDEX_op_movi_i64: >>> + case INDEX_op_movi_i32: >>> + /* Always implemented with tcg_out_mov/i, never with tcg_out_op. */ >>> default: >>> - tcg_abort(); /* opcode not implemented */ >>> + /* Opcode not implemented. */ >>> + tcg_abort(); >>> } >>> } >>> >> >> Ok > > Sadly, "Ok" is neither Reviewed-by or Signed-off-by. > > There is nothing sad about it. When it's reviewed, you will know.
On 12 September 2013 15:31, Claudio Fontana <claudio.fontana@huawei.com> wrote: > On 12.09.2013 16:02, Richard Henderson wrote: >> On 09/12/2013 01:30 AM, Claudio Fontana wrote: >>> Ok >> >> Sadly, "Ok" is neither Reviewed-by or Signed-off-by > There is nothing sad about it. When it's reviewed, you will know. The point is that "Ok" is not particularly useful feedback because it looks like a reviewd-by/acked-by but isn't. It's confusing so it's better to avoid it. -- PMM
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index bde4c72..79a447d 100644 --- a/tcg/aarch64/tcg-target.c +++ b/tcg/aarch64/tcg-target.c @@ -1162,18 +1162,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, args[0], args[1], args[2]); break; - case INDEX_op_mov_i64: - case INDEX_op_mov_i32: - tcg_out_movr(s, ext, args[0], args[1]); - break; - - case INDEX_op_movi_i64: - tcg_out_movi(s, TCG_TYPE_I64, args[0], args[1]); - break; - case INDEX_op_movi_i32: - tcg_out_movi(s, TCG_TYPE_I32, args[0], args[1]); - break; - case INDEX_op_add_i64: case INDEX_op_add_i32: tcg_out_arith(s, ARITH_ADD, ext, args[0], args[1], args[2], 0); @@ -1337,8 +1325,14 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, tcg_out_movr(s, 0, args[0], args[1]); break; + case INDEX_op_mov_i64: + case INDEX_op_mov_i32: + case INDEX_op_movi_i64: + case INDEX_op_movi_i32: + /* Always implemented with tcg_out_mov/i, never with tcg_out_op. */ default: - tcg_abort(); /* opcode not implemented */ + /* Opcode not implemented. */ + tcg_abort(); } }
Signed-off-by: Richard Henderson <rth@twiddle.net> --- tcg/aarch64/tcg-target.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-)