| Message ID | 1368597869-30405-1-git-send-email-hutao@cn.fujitsu.com |
|---|---|
| State | New |
| Headers | show |
On 15 May 2013 07:04, Hu Tao <hutao@cn.fujitsu.com> wrote: > target_phys_addr_t has been already replaced by hwaddr, but this > one is introduced after. > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> This doesn't cause compile errors because it's in a bit of code that can never get compiled (it's inside a CONFIG_USER_ONLY block but there is no moxie-linux-user target in configure). thanks -- PMM
Anthony G., Am 15.05.2013 10:23, schrieb Peter Maydell: > On 15 May 2013 07:04, Hu Tao <hutao@cn.fujitsu.com> wrote: >> target_phys_addr_t has been already replaced by hwaddr, but this >> one is introduced after. >> >> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > This doesn't cause compile errors because it's in a bit > of code that can never get compiled (it's inside a > CONFIG_USER_ONLY block but there is no moxie-linux-user > target in configure). A similar issue had come up before and I don't remember seeing a clear answer: Are you planning to actually implement moxie-linux-user and enable it by default, so that we can catch any errors? Or should we rather drop any such unused CONFIG_USER_ONLY code from target-moxie? Regards, Andreas
15.05.2013 10:04, Hu Tao wrote: > target_phys_addr_t has been already replaced by hwaddr, but this > one is introduced after. > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> Thanks, added to the trivial patches queue. /mjt
diff --git a/target-moxie/helper.c b/target-moxie/helper.c index 6e0ac2a..5cfe889 100644 --- a/target-moxie/helper.c +++ b/target-moxie/helper.c @@ -116,7 +116,7 @@ int cpu_moxie_handle_mmu_fault(CPUMoxieState *env, target_ulong address, return 1; } -target_phys_addr_t cpu_get_phys_page_debug(CPUState *env, target_ulong addr) +hwaddr cpu_get_phys_page_debug(CPUState *env, target_ulong addr) { return addr; }
target_phys_addr_t has been already replaced by hwaddr, but this one is introduced after. Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- target-moxie/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)