| Message ID | 20090206180659.GI11548@oksana.dev.rtsoft.ru (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Kumar Gala |
| Headers | show |
On Fri, 6 Feb 2009 21:06:59 +0300 Anton Vorontsov <avorontsov@ru.mvista.com> wrote: > FSL eSDHC hosts have incompatible register map to manage the SDCLK. > This patch adds set_clock callback so that drivers could overwrite > set_clock behaviour. > > Similar patch[1] was posted by Ben Dooks, though in Ben's version the > callback is named change_clock, plus the patch has some unrelated bits > that makes the patch difficult to reuse. > > [1] http://lkml.org/lkml/2008/12/2/160 > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > --- A set_clock() callback is reasonable as there might be a clock source that needs to be set up, but completely overriding the normal routine (i.e. the "return") should be quirked IMO. Rgds
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 0293368..3c1f1d5 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -969,6 +969,11 @@ static void sdhci_set_clock(struct sdhci_host *host, unsigned int clock) if (clock == host->clock) return; + if (host->ops->set_clock) { + host->ops->set_clock(host, clock); + return; + } + sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL); if (clock == 0) diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 2e8dfd1..497276b 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h @@ -312,6 +312,8 @@ struct sdhci_ops { void (*writew)(struct sdhci_host *host, u16 val, sdhci_reg_t reg); void (*writeb)(struct sdhci_host *host, u8 val, sdhci_reg_t reg); + void (*set_clock)(struct sdhci_host *host, unsigned int clock); + int (*enable_dma)(struct sdhci_host *host); };
FSL eSDHC hosts have incompatible register map to manage the SDCLK. This patch adds set_clock callback so that drivers could overwrite set_clock behaviour. Similar patch[1] was posted by Ben Dooks, though in Ben's version the callback is named change_clock, plus the patch has some unrelated bits that makes the patch difficult to reuse. [1] http://lkml.org/lkml/2008/12/2/160 Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- drivers/mmc/host/sdhci.c | 5 +++++ drivers/mmc/host/sdhci.h | 2 ++ 2 files changed, 7 insertions(+), 0 deletions(-)