| Message ID | 1360182113-23743-1-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Accepted |
| Commit | 2356d08bbdf18677e14cb21d18c9e024e749d50b |
| Headers | show |
On 06/02/13 21:21, Gustavo Zacarias wrote: > Update {ea3250,fdi3250,phy3250}_defconfig to lock down kernel headers to > an appropiate version. > Otherwise the target is building with, at the moment of this writing, > version 3.7 headers and a 2.6.34 kernel which usually isn't wise. This should really be done for all defconfigs that build a custom kernel version: arm_foundationv8_defconfig armadeus_apf9328_defconfig at91sam9g20dfc_defconfig atstk100x_defconfig beaglebone_defconfig calao_snowball_defconfig kb9202_defconfig mini2440_defconfig mx53loco_defconfig sheevaplug_defconfig And the ones that allow it should probably set BR2_LINUX_KERNEL_SAME_AS_HEADERS. But all that is a lot of testing :-) > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > configs/ea3250_defconfig | 4 ++++ > configs/fdi3250_defconfig | 4 ++++ > configs/phy3250_defconfig | 4 ++++ > 3 files changed, 12 insertions(+) > > diff --git a/configs/ea3250_defconfig b/configs/ea3250_defconfig > index 9cd7b34..2574dde 100644 > --- a/configs/ea3250_defconfig > +++ b/configs/ea3250_defconfig > @@ -11,6 +11,10 @@ BR2_ARM_EABI=y > # that will compile a kernel with ethernet working correctly > BR2_GCC_VERSION_4_3_X=y > > +# Lock down headers to avoid breaking with new defaults > +BR2_KERNEL_HEADERS_VERSION=y > +BR2_DEFAULT_KERNEL_VERSION="2.6.34.7" > +BR2_DEFAULT_KERNEL_HEADERS="2.6.34.7" Only BR2_DEFAULT_KERNEL_VERSION is necessary - BR2_DEFAULT_KERNEL_HEADERS is derived from it by Kconfig. Regards, Arnout
On 02/06/2013 05:42 PM, Arnout Vandecappelle wrote: > This should really be done for all defconfigs that build a custom > kernel version: > > arm_foundationv8_defconfig > armadeus_apf9328_defconfig > at91sam9g20dfc_defconfig > atstk100x_defconfig > beaglebone_defconfig > calao_snowball_defconfig > kb9202_defconfig > mini2440_defconfig > mx53loco_defconfig > sheevaplug_defconfig > > And the ones that allow it should probably set > BR2_LINUX_KERNEL_SAME_AS_HEADERS. > > But all that is a lot of testing :-) Yes, i'm sending as i'm testing :) I'll also be switching these ones (*3250*) configs to git tags/releases != master because there's a filename clash possibility there. Not at the moment though since those use the same upstream and no other BSP config does that, but it could happen. > Only BR2_DEFAULT_KERNEL_VERSION is necessary - > BR2_DEFAULT_KERNEL_HEADERS is derived from it by Kconfig. Cool, i'll minimize them then. Regards.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
Gustavo> Update {ea3250,fdi3250,phy3250}_defconfig to lock down kernel headers to
Gustavo> an appropiate version.
Gustavo> Otherwise the target is building with, at the moment of this writing,
Gustavo> version 3.7 headers and a 2.6.34 kernel which usually isn't wise.
Committed, thanks.
diff --git a/configs/ea3250_defconfig b/configs/ea3250_defconfig index 9cd7b34..2574dde 100644 --- a/configs/ea3250_defconfig +++ b/configs/ea3250_defconfig @@ -11,6 +11,10 @@ BR2_ARM_EABI=y # that will compile a kernel with ethernet working correctly BR2_GCC_VERSION_4_3_X=y +# Lock down headers to avoid breaking with new defaults +BR2_KERNEL_HEADERS_VERSION=y +BR2_DEFAULT_KERNEL_VERSION="2.6.34.7" +BR2_DEFAULT_KERNEL_HEADERS="2.6.34.7" # # Host utilities diff --git a/configs/fdi3250_defconfig b/configs/fdi3250_defconfig index 1fd0b05..b1c6684 100644 --- a/configs/fdi3250_defconfig +++ b/configs/fdi3250_defconfig @@ -11,6 +11,10 @@ BR2_ARM_EABI=y # that will compile a kernel with ethernet working correctly BR2_GCC_VERSION_4_3_X=y +# Lock down headers to avoid breaking with new defaults +BR2_KERNEL_HEADERS_VERSION=y +BR2_DEFAULT_KERNEL_VERSION="2.6.34.7" +BR2_DEFAULT_KERNEL_HEADERS="2.6.34.7" # # Host utilities diff --git a/configs/phy3250_defconfig b/configs/phy3250_defconfig index bc17d5c..e95546f 100644 --- a/configs/phy3250_defconfig +++ b/configs/phy3250_defconfig @@ -11,6 +11,10 @@ BR2_ARM_EABI=y # that will compile a kernel with ethernet working correctly BR2_GCC_VERSION_4_3_X=y +# Lock down headers to avoid breaking with new defaults +BR2_KERNEL_HEADERS_VERSION=y +BR2_DEFAULT_KERNEL_VERSION="2.6.34.7" +BR2_DEFAULT_KERNEL_HEADERS="2.6.34.7" # # Host utilities
Update {ea3250,fdi3250,phy3250}_defconfig to lock down kernel headers to an appropiate version. Otherwise the target is building with, at the moment of this writing, version 3.7 headers and a 2.6.34 kernel which usually isn't wise. Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- configs/ea3250_defconfig | 4 ++++ configs/fdi3250_defconfig | 4 ++++ configs/phy3250_defconfig | 4 ++++ 3 files changed, 12 insertions(+)