Message ID | 20121229211050.3249f8b7@black |
---|---|
State | RFC |
Headers | show |
Dear Jeroen Hofstee, In message <20121229211050.3249f8b7@black> you wrote: > > My apologies, I pasted half the patch, the intention is to always > set addr = gd->fb_base. No, this is not correct. If CONFIG_FB_ADDR is set, then it will usually points to the start address of an on on-chip video memory region. There will be no RAM below this aread to relocate U-Boot to, i. e. you patch will break a number of systems. Best regards, Wolfgang Denk
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index e0cb635..4d0fc3c 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -371,9 +371,10 @@ void board_init_f(ulong bootflag) gd->fb_base = CONFIG_FB_ADDR; #else /* reserve memory for LCD display (always full pages) */ - addr = lcd_setmem(addr); - gd->fb_base = addr; + gd->fb_base = lcd_setmem(addr); #endif /* CONFIG_FB_ADDR */ + /* always continue placement below the frame buffer to not overlap */ + addr = gd->fb_base; #endif /* CONFIG_LCD */