| Message ID | 8000c1db5e735e027860a47bde50d64ea4a96893.1353660725.git.mprivozn@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 23 November 2012 08:52, Michal Privoznik <mprivozn@redhat.com> wrote: > There's no need to add a space at the end of line. > Moreover, it can make problems in some projects that > store the help output into a file (and run couple of > tests based on that) and have space at EOL forbidden. I have no problem with this patch but I would suggest that these other projects have a broken workflow if they're reliant on QEMU's help output to not have trailing spaces like that :-) > Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> (and cc'd qemu-trivial). -- PMM > --- > qemu-options.hx | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 9bb29d3..8f6d0e3 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1331,7 +1331,7 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, > " connect the host TAP network interface to VLAN 'n'\n" > #else > "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile][,helper=helper][,sndbuf=nbytes][,vnet_hdr=on|off][,vhost=on|off][,vhostfd=h][,vhostforce=on|off]\n" > - " connect the host TAP network interface to VLAN 'n' \n" > + " connect the host TAP network interface to VLAN 'n'\n" > " use network scripts 'file' (default=" DEFAULT_NETWORK_SCRIPT ")\n" > " to configure it and 'dfile' (default=" DEFAULT_NETWORK_DOWN_SCRIPT ")\n" > " to deconfigure it\n"
On Fri, Nov 23, 2012 at 09:52:39AM +0100, Michal Privoznik wrote: > There's no need to add a space at the end of line. > Moreover, it can make problems in some projects that > store the help output into a file (and run couple of > tests based on that) and have space at EOL forbidden. > > Signed-off-by: Michal Privoznik <mprivozn@redhat.com> > --- > qemu-options.hx | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan
diff --git a/qemu-options.hx b/qemu-options.hx index 9bb29d3..8f6d0e3 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1331,7 +1331,7 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, " connect the host TAP network interface to VLAN 'n'\n" #else "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile][,helper=helper][,sndbuf=nbytes][,vnet_hdr=on|off][,vhost=on|off][,vhostfd=h][,vhostforce=on|off]\n" - " connect the host TAP network interface to VLAN 'n' \n" + " connect the host TAP network interface to VLAN 'n'\n" " use network scripts 'file' (default=" DEFAULT_NETWORK_SCRIPT ")\n" " to configure it and 'dfile' (default=" DEFAULT_NETWORK_DOWN_SCRIPT ")\n" " to deconfigure it\n"
There's no need to add a space at the end of line. Moreover, it can make problems in some projects that store the help output into a file (and run couple of tests based on that) and have space at EOL forbidden. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- qemu-options.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)