| Message ID | 1353146744-13529-1-git-send-email-francois.perrad@gadz.org |
|---|---|
| State | Rejected |
| Headers | show |
>>>>> "Francois" == Francois Perrad <fperrad@gmail.com> writes:
Francois> see https://bugs.busybox.net/show_bug.cgi?id=5354
Thanks, but I don't get the problem in the first place. Lua links
lua/luac using gcc, so why doesn't it pick up the stack protection bits?
Francois> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Francois> ---
Francois> package/lua/lua.mk | 2 +-
Francois> 1 file changed, 1 insertion(+), 1 deletion(-)
Francois> diff --git a/package/lua/lua.mk b/package/lua/lua.mk
Francois> index 9e0d387..3ce9867 100644
Francois> --- a/package/lua/lua.mk
Francois> +++ b/package/lua/lua.mk
Francois> @@ -24,7 +24,7 @@ endif
Francois> # We never want to have host-readline and host-ncurses as dependencies
Francois> # of host-lua.
Francois> HOST_LUA_DEPENDENCIES =
Francois> -HOST_LUA_CFLAGS = -Wall -fPIC -DLUA_USE_DLOPEN -DLUA_USE_POSIX
Francois> +HOST_LUA_CFLAGS = -Wall -fPIC -fno-stack-protector -DLUA_USE_DLOPEN -DLUA_USE_POSIX
Francois> HOST_LUA_MYLIBS = -ldl
Francois> define LUA_BUILD_CMDS
Francois> --
Francois> 1.7.9.5
Francois> _______________________________________________
Francois> buildroot mailing list
Francois> buildroot@busybox.net
Francois> http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Peter" == Peter Korsgaard <jacmet@uclibc.org> writes:
Francois> see https://bugs.busybox.net/show_bug.cgi?id=5354
Peter> Thanks, but I don't get the problem in the first place. Lua links
Peter> lua/luac using gcc, so why doesn't it pick up the stack protection bits?
Ahh, I see it now - It's because we're passing -nostdlib -lgcc when
creating the shared library. Why are we doing that in the first place?
Gustavo, it seems to date back to 46913a2d4. Do you have any idea why it
was done like that?
On 11/17/2012 04:56 PM, Peter Korsgaard wrote: > Ahh, I see it now - It's because we're passing -nostdlib -lgcc when > creating the shared library. Why are we doing that in the first place? > > Gustavo, it seems to date back to 46913a2d4. Do you have any idea why it > was done like that? https://bugs.busybox.net/show_bug.cgi?id=803 has rvpaasen's work, i just reworked it IIRC. OpenWRT doesn't try to link to libgcc or ditch the standard startup and libraries, it's worth a try to kill that bit. Regards.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes: Hi, >> Ahh, I see it now - It's because we're passing -nostdlib -lgcc when >> creating the shared library. Why are we doing that in the first place? >> >> Gustavo, it seems to date back to 46913a2d4. Do you have any idea why it >> was done like that? Gustavo> https://bugs.busybox.net/show_bug.cgi?id=803 has rvpaasen's Gustavo> work, i just reworked it IIRC. OpenWRT doesn't try to link to Gustavo> libgcc or ditch the standard startup and libraries, it's worth Gustavo> a try to kill that bit. Ok, done.
diff --git a/package/lua/lua.mk b/package/lua/lua.mk index 9e0d387..3ce9867 100644 --- a/package/lua/lua.mk +++ b/package/lua/lua.mk @@ -24,7 +24,7 @@ endif # We never want to have host-readline and host-ncurses as dependencies # of host-lua. HOST_LUA_DEPENDENCIES = -HOST_LUA_CFLAGS = -Wall -fPIC -DLUA_USE_DLOPEN -DLUA_USE_POSIX +HOST_LUA_CFLAGS = -Wall -fPIC -fno-stack-protector -DLUA_USE_DLOPEN -DLUA_USE_POSIX HOST_LUA_MYLIBS = -ldl define LUA_BUILD_CMDS
see https://bugs.busybox.net/show_bug.cgi?id=5354 Signed-off-by: Francois Perrad <francois.perrad@gadz.org> --- package/lua/lua.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)