| Message ID | 1351666334.32304.13.camel@hbabu-laptop (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Benjamin Herrenschmidt |
| Headers | show |
On Oct 31, 2012, at 1:52 AM, Haren Myneni wrote: > [PATCH 2/6] powerpc: Define CPU_FTR_HAS_PPR > > CPU_FTR_HAS_PPR is defined for POWER7. Would be nice if commit message spelled out what PPR is. > > Signed-off-by: Haren Myneni <haren@us.ibm.com> > --- > arch/powerpc/include/asm/cputable.h | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-)
On 10/31/2012 06:25 AM, Kumar Gala wrote: > > On Oct 31, 2012, at 1:52 AM, Haren Myneni wrote: > >> [PATCH 2/6] powerpc: Define CPU_FTR_HAS_PPR >> >> CPU_FTR_HAS_PPR is defined for POWER7. > > Would be nice if commit message spelled out what PPR is. > Thanks, First patch described what PPR is. Agree, I will change this commit. >> >> Signed-off-by: Haren Myneni <haren@us.ibm.com> >> --- >> arch/powerpc/include/asm/cputable.h | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev >
Heaven Myneni <haren@linux.vnet.ibm.com> wrote: > [PATCH 2/6] powerpc: Define CPU_FTR_HAS_PPR > > CPU_FTR_HAS_PPR is defined for POWER7. > > Signed-off-by: Haren Myneni <haren@us.ibm.com> > --- > arch/powerpc/include/asm/cputable.h | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/include/asm/cputable.h b/arch/powerpc/include/asm/cputable.h > index 21a0687..12e3a1d 100644 > --- a/arch/powerpc/include/asm/cputable.h > +++ b/arch/powerpc/include/asm/cputable.h > @@ -171,6 +171,7 @@ extern const char *powerpc_base_platform; > #define CPU_FTR_POPCNTD LONG_ASM_CONST(0x0800000000000000) > #define CPU_FTR_ICSWX LONG_ASM_CONST(0x1000000000000000) > #define CPU_FTR_VMX_COPY LONG_ASM_CONST(0x2000000000000000) > +#define CPU_FTR_HAS_PPR LONG_ASM_CONST(0x4000000000000000) > > #ifndef __ASSEMBLY__ > > @@ -400,7 +401,8 @@ extern const char *powerpc_base_platform; > CPU_FTR_PURR | CPU_FTR_SPURR | CPU_FTR_REAL_LE | \ > CPU_FTR_DSCR | CPU_FTR_SAO | CPU_FTR_ASYM_SMT | \ > CPU_FTR_STCX_CHECKS_ADDRESS | CPU_FTR_POPCNTB | CPU_FTR_POPCNTD | \ > - CPU_FTR_ICSWX | CPU_FTR_CFAR | CPU_FTR_HVMODE | CPU_FTR_VMX_COPY) > + CPU_FTR_ICSWX | CPU_FTR_CFAR | CPU_FTR_HVMODE | \ > + CPU_FTR_VMX_COPY | CPU_FTR_HAS_PPR) > #define CPU_FTRS_CELL (CPU_FTR_USE_TB | CPU_FTR_LWSYNC | \ > CPU_FTR_PPCAS_ARCH_V2 | CPU_FTR_CTRL | \ > CPU_FTR_ALTIVEC_COMP | CPU_FTR_MMCRA | CPU_FTR_SMT | \ > @@ -422,7 +424,7 @@ extern const char *powerpc_base_platform; > (CPU_FTRS_POWER3 | CPU_FTRS_RS64 | CPU_FTRS_POWER4 | \ > CPU_FTRS_PPC970 | CPU_FTRS_POWER5 | CPU_FTRS_POWER6 | \ > CPU_FTRS_POWER7 | CPU_FTRS_CELL | CPU_FTRS_PA6T | \ > - CPU_FTR_VSX) > + CPU_FTR_VSX | CPU_FTR_HAS_PPR) FYI, there is no need to add this to POSSIBLE, since you are adding it to POWER7 anyway. Mikey
On 11/22/2012 08:01 PM, Michael Neuling wrote: > Heaven Myneni <haren@linux.vnet.ibm.com> wrote: > >> [PATCH 2/6] powerpc: Define CPU_FTR_HAS_PPR >> >> CPU_FTR_HAS_PPR is defined for POWER7. >> >> Signed-off-by: Haren Myneni <haren@us.ibm.com> >> --- >> arch/powerpc/include/asm/cputable.h | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/arch/powerpc/include/asm/cputable.h b/arch/powerpc/include/asm/cputable.h >> index 21a0687..12e3a1d 100644 >> --- a/arch/powerpc/include/asm/cputable.h >> +++ b/arch/powerpc/include/asm/cputable.h >> @@ -171,6 +171,7 @@ extern const char *powerpc_base_platform; >> #define CPU_FTR_POPCNTD LONG_ASM_CONST(0x0800000000000000) >> #define CPU_FTR_ICSWX LONG_ASM_CONST(0x1000000000000000) >> #define CPU_FTR_VMX_COPY LONG_ASM_CONST(0x2000000000000000) >> +#define CPU_FTR_HAS_PPR LONG_ASM_CONST(0x4000000000000000) >> >> #ifndef __ASSEMBLY__ >> >> @@ -400,7 +401,8 @@ extern const char *powerpc_base_platform; >> CPU_FTR_PURR | CPU_FTR_SPURR | CPU_FTR_REAL_LE | \ >> CPU_FTR_DSCR | CPU_FTR_SAO | CPU_FTR_ASYM_SMT | \ >> CPU_FTR_STCX_CHECKS_ADDRESS | CPU_FTR_POPCNTB | CPU_FTR_POPCNTD | \ >> - CPU_FTR_ICSWX | CPU_FTR_CFAR | CPU_FTR_HVMODE | CPU_FTR_VMX_COPY) >> + CPU_FTR_ICSWX | CPU_FTR_CFAR | CPU_FTR_HVMODE | \ >> + CPU_FTR_VMX_COPY | CPU_FTR_HAS_PPR) >> #define CPU_FTRS_CELL (CPU_FTR_USE_TB | CPU_FTR_LWSYNC | \ >> CPU_FTR_PPCAS_ARCH_V2 | CPU_FTR_CTRL | \ >> CPU_FTR_ALTIVEC_COMP | CPU_FTR_MMCRA | CPU_FTR_SMT | \ >> @@ -422,7 +424,7 @@ extern const char *powerpc_base_platform; >> (CPU_FTRS_POWER3 | CPU_FTRS_RS64 | CPU_FTRS_POWER4 | \ >> CPU_FTRS_PPC970 | CPU_FTRS_POWER5 | CPU_FTRS_POWER6 | \ >> CPU_FTRS_POWER7 | CPU_FTRS_CELL | CPU_FTRS_PA6T | \ >> - CPU_FTR_VSX) >> + CPU_FTR_VSX | CPU_FTR_HAS_PPR) > > FYI, there is no need to add this to POSSIBLE, since you are adding it > to POWER7 anyway. Will remove CPU_FTR_HAS_PPR for POSSIBLE macro. Added this in second version for enabling this feature with command parameter, but forgot to remove it. Thanks Haren > > Mikey >
diff --git a/arch/powerpc/include/asm/cputable.h b/arch/powerpc/include/asm/cputable.h index 21a0687..12e3a1d 100644 --- a/arch/powerpc/include/asm/cputable.h +++ b/arch/powerpc/include/asm/cputable.h @@ -171,6 +171,7 @@ extern const char *powerpc_base_platform; #define CPU_FTR_POPCNTD LONG_ASM_CONST(0x0800000000000000) #define CPU_FTR_ICSWX LONG_ASM_CONST(0x1000000000000000) #define CPU_FTR_VMX_COPY LONG_ASM_CONST(0x2000000000000000) +#define CPU_FTR_HAS_PPR LONG_ASM_CONST(0x4000000000000000) #ifndef __ASSEMBLY__ @@ -400,7 +401,8 @@ extern const char *powerpc_base_platform; CPU_FTR_PURR | CPU_FTR_SPURR | CPU_FTR_REAL_LE | \ CPU_FTR_DSCR | CPU_FTR_SAO | CPU_FTR_ASYM_SMT | \ CPU_FTR_STCX_CHECKS_ADDRESS | CPU_FTR_POPCNTB | CPU_FTR_POPCNTD | \ - CPU_FTR_ICSWX | CPU_FTR_CFAR | CPU_FTR_HVMODE | CPU_FTR_VMX_COPY) + CPU_FTR_ICSWX | CPU_FTR_CFAR | CPU_FTR_HVMODE | \ + CPU_FTR_VMX_COPY | CPU_FTR_HAS_PPR) #define CPU_FTRS_CELL (CPU_FTR_USE_TB | CPU_FTR_LWSYNC | \ CPU_FTR_PPCAS_ARCH_V2 | CPU_FTR_CTRL | \ CPU_FTR_ALTIVEC_COMP | CPU_FTR_MMCRA | CPU_FTR_SMT | \ @@ -422,7 +424,7 @@ extern const char *powerpc_base_platform; (CPU_FTRS_POWER3 | CPU_FTRS_RS64 | CPU_FTRS_POWER4 | \ CPU_FTRS_PPC970 | CPU_FTRS_POWER5 | CPU_FTRS_POWER6 | \ CPU_FTRS_POWER7 | CPU_FTRS_CELL | CPU_FTRS_PA6T | \ - CPU_FTR_VSX) + CPU_FTR_VSX | CPU_FTR_HAS_PPR) #endif #else enum {
[PATCH 2/6] powerpc: Define CPU_FTR_HAS_PPR CPU_FTR_HAS_PPR is defined for POWER7. Signed-off-by: Haren Myneni <haren@us.ibm.com> --- arch/powerpc/include/asm/cputable.h | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)