| Message ID | 1350547326-31407-1-git-send-email-maxime.ripard@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | f72b561789032b69e7fa62479abd34259731605c |
| Headers | show |
On 18/10/12 10:02, Maxime Ripard wrote: > Signed-off-by: Maxime Ripard<maxime.ripard@free-electrons.com> > --- > boot/mxs-bootlets/barebox_ivt.bd | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/boot/mxs-bootlets/barebox_ivt.bd b/boot/mxs-bootlets/barebox_ivt.bd > index e02ddd6..0c67e9c 100644 > --- a/boot/mxs-bootlets/barebox_ivt.bd > +++ b/boot/mxs-bootlets/barebox_ivt.bd > @@ -28,7 +28,7 @@ section (0) { > //---------------------------------------------------------- > > load barebox; > - load ivt (entry = barebox:exception_vectors)> 0x8000; > + load ivt (entry = barebox:start)> 0x8000; > hab call 0x8000; > > } Shouldn't this somehow depend on the selected barebox version then? Regards, Arnout
Hi Arnout, Le 18/10/2012 21:53, Arnout Vandecappelle a écrit : > On 18/10/12 10:02, Maxime Ripard wrote: >> Signed-off-by: Maxime Ripard<maxime.ripard@free-electrons.com> >> --- >> boot/mxs-bootlets/barebox_ivt.bd | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/boot/mxs-bootlets/barebox_ivt.bd >> b/boot/mxs-bootlets/barebox_ivt.bd >> index e02ddd6..0c67e9c 100644 >> --- a/boot/mxs-bootlets/barebox_ivt.bd >> +++ b/boot/mxs-bootlets/barebox_ivt.bd >> @@ -28,7 +28,7 @@ section (0) { >> //---------------------------------------------------------- >> >> load barebox; >> - load ivt (entry = barebox:exception_vectors)> 0x8000; >> + load ivt (entry = barebox:start)> 0x8000; >> hab call 0x8000; >> >> } > > Shouldn't this somehow depend on the selected barebox version then? Well, I thought so at first, but since the next barebox release is in less than two weeks now, and the 2012.07 (the only one we support that is still using exception_vectors symbol) will be removed at that time, so I finally gave up to write that code, just to have it removed/be irrelevant in two weeks. Maxime
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes: >> load barebox; >> - load ivt (entry = barebox:exception_vectors)> 0x8000; >> + load ivt (entry = barebox:start)> 0x8000; >> hab call 0x8000; >> >> } Arnout> Shouldn't this somehow depend on the selected barebox version then? Indeed. What happens if people use <2012.08?
Le 19/10/2012 11:00, Peter Korsgaard a écrit : >>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes: > > >> load barebox; > >> - load ivt (entry = barebox:exception_vectors)> 0x8000; > >> + load ivt (entry = barebox:start)> 0x8000; > >> hab call 0x8000; > >> > >> } > > Arnout> Shouldn't this somehow depend on the selected barebox version then? > > Indeed. What happens if people use <2012.08? It will fail to execute barebox, and will loop trying to execute it. But once again, if things go as usual, this is only a matter of two weeks... I can resubmit in two weeks if you prefer.
Hi Peter, Le 18/10/2012 10:02, Maxime Ripard a écrit : > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > boot/mxs-bootlets/barebox_ivt.bd | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/boot/mxs-bootlets/barebox_ivt.bd b/boot/mxs-bootlets/barebox_ivt.bd > index e02ddd6..0c67e9c 100644 > --- a/boot/mxs-bootlets/barebox_ivt.bd > +++ b/boot/mxs-bootlets/barebox_ivt.bd > @@ -28,7 +28,7 @@ section (0) { > //---------------------------------------------------------- > > load barebox; > - load ivt (entry = barebox:exception_vectors) > 0x8000; > + load ivt (entry = barebox:start) > 0x8000; > hab call 0x8000; > > } Can we apply this patch now that all supported barebox versions have this entry point ? Thanks, Maxime
>>>>> "Maxime" == Maxime Ripard <maxime.ripard@free-electrons.com> writes: >> load barebox; >> - load ivt (entry = barebox:exception_vectors) > 0x8000; >> + load ivt (entry = barebox:start) > 0x8000; >> hab call 0x8000; >> >> } Maxime> Can we apply this patch now that all supported barebox versions have Maxime> this entry point ? Yes, will do so now. Thanks for reminding me.
>>>>> "Maxime" == Maxime Ripard <maxime.ripard@free-electrons.com> writes:
Maxime> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Committed, thanks.
diff --git a/boot/mxs-bootlets/barebox_ivt.bd b/boot/mxs-bootlets/barebox_ivt.bd index e02ddd6..0c67e9c 100644 --- a/boot/mxs-bootlets/barebox_ivt.bd +++ b/boot/mxs-bootlets/barebox_ivt.bd @@ -28,7 +28,7 @@ section (0) { //---------------------------------------------------------- load barebox; - load ivt (entry = barebox:exception_vectors) > 0x8000; + load ivt (entry = barebox:start) > 0x8000; hab call 0x8000; }
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- boot/mxs-bootlets/barebox_ivt.bd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)