| Message ID | 1348915975-18500-1-git-send-email-agust@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Sat, 29 Sep 2012 12:52:55 +0200 Anatolij Gustschin <agust@denx.de> wrote: > Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 > (cmd_fat: use common get_device_and_partition function) > introduced a warning: > cmd_fat.c: In function 'do_fat_fswrite': > cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable] > > Fix it. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > common/cmd_fat.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Reported-by: Albert ARIBAUD <albert.u.boot@aribaud.net> I forgot to add attribution tag, so resending. patchwork hopefully will add it when picking the patch. Thanks, Anatolij
Hi Anatolij, On Sat, 29 Sep 2012 13:14:13 +0200, Anatolij Gustschin <agust@denx.de> wrote: > On Sat, 29 Sep 2012 12:52:55 +0200 > Anatolij Gustschin <agust@denx.de> wrote: > > > Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 > > (cmd_fat: use common get_device_and_partition function) > > introduced a warning: > > cmd_fat.c: In function 'do_fat_fswrite': > > cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable] > > > > Fix it. > > > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > > --- > > common/cmd_fat.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > Reported-by: Albert ARIBAUD <albert.u.boot@aribaud.net> > > I forgot to add attribution tag, so resending. patchwork hopefully > will add it when picking the patch. For the record, it fixes the build issue. As the fix is trivial, Tested-by: Albert ARIBAUD <albert.u.boot@aribaud.net> > Thanks, > Anatolij Amicalement,
On Sat, Sep 29, 2012 at 12:52:55PM +0200, Anatolij Gustschin wrote: > Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 > (cmd_fat: use common get_device_and_partition function) > introduced a warning: > cmd_fat.c: In function 'do_fat_fswrite': > cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable] > > Fix it. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> Applied to u-boot/master, thanks (and patchwork picked up the tags)!
diff --git a/common/cmd_fat.c b/common/cmd_fat.c index 55585c6..5a5698b 100644 --- a/common/cmd_fat.c +++ b/common/cmd_fat.c @@ -175,7 +175,6 @@ static int do_fat_fswrite(cmd_tbl_t *cmdtp, int flag, disk_partition_t info; int dev = 0; int part = 1; - char *ep; if (argc < 5) return cmd_usage(cmdtp);
Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 (cmd_fat: use common get_device_and_partition function) introduced a warning: cmd_fat.c: In function 'do_fat_fswrite': cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable] Fix it. Signed-off-by: Anatolij Gustschin <agust@denx.de> --- common/cmd_fat.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)