diff mbox

[U-Boot,1/6] SPL: Add NOR flash booting support

Message ID 1345709565-28862-2-git-send-email-sr@denx.de
State Superseded
Headers show

Commit Message

Stefan Roese Aug. 23, 2012, 8:12 a.m. UTC 
SPL NOR flash booting support is quite simple. Only copying of the
images is needed.

On MPC5xxx we need to make sure to only use the standard memcpy()
implementation and not the MPC5xxx specific one. As the MPC5xxx
version has some complexity which is not needed for this SPL
booting.

Signed-off-by: Stefan Roese <sr@denx.de>
---
 common/spl/Makefile  |  1 +
 common/spl/spl.c     |  5 ++++
 common/spl/spl_nor.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 include/spl.h        |  3 +++
 4 files changed, 77 insertions(+)
 create mode 100644 common/spl/spl_nor.c

Comments

Tom Rini Aug. 23, 2012, 3:07 p.m. UTC | #1 
On 08/23/2012 01:12 AM, Stefan Roese wrote:
> SPL NOR flash booting support is quite simple. Only copying of the
> images is needed.
> 
> On MPC5xxx we need to make sure to only use the standard memcpy()
> implementation and not the MPC5xxx specific one. As the MPC5xxx
> version has some complexity which is not needed for this SPL
> booting.

I assume there's good reason to use SPL on NOR here?  Is a near-future
goal to do SPL-boots-Linux and thus the desire for a very small loader?
 Thanks!
Stefan Roese Aug. 23, 2012, 3:19 p.m. UTC | #2 
On 08/23/2012 05:07 PM, Tom Rini wrote:
> On 08/23/2012 01:12 AM, Stefan Roese wrote:
>> SPL NOR flash booting support is quite simple. Only copying of the
>> images is needed.
>>
>> On MPC5xxx we need to make sure to only use the standard memcpy()
>> implementation and not the MPC5xxx specific one. As the MPC5xxx
>> version has some complexity which is not needed for this SPL
>> booting.
> 
> I assume there's good reason to use SPL on NOR here?  Is a near-future
> goal to do SPL-boots-Linux and thus the desire for a very small loader?

Yes. As explained in the cover-letter, the board port using this SPL NOR
support (MPC5200 based) mainly uses this SPL framework to speed up
booting into Linux. Less code loaded from NOR, zero relocation (on this
PPC port at least), etc.

My first quick tests show a boot to Linux speedup by approx. 0.5 seconds
compared to the good-old U-Boot -> Linux booting. So it definitely makes
sense in time-critical bootup situation.

Thanks,
Stefan
diff mbox

Patch

diff --git a/common/spl/Makefile b/common/spl/Makefile
index b61b438..53a82c4 100644
--- a/common/spl/Makefile
+++ b/common/spl/Makefile
@@ -15,6 +15,7 @@  LIB	= $(obj)libspl.o
 
 ifdef CONFIG_SPL_BUILD
 COBJS-$(CONFIG_SPL_FRAMEWORK) += spl.o
+COBJS-$(CONFIG_SPL_NOR_SUPPORT) += spl_nor.o
 COBJS-$(CONFIG_SPL_YMODEM_SUPPORT) += spl_ymodem.o
 endif
 
diff --git a/common/spl/spl.c b/common/spl/spl.c
index dcf8556..4c0135e 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -170,6 +170,11 @@  void board_init_r(gd_t *id, ulong dummy)
 		spl_nand_load_image();
 		break;
 #endif
+#ifdef CONFIG_SPL_NOR_SUPPORT
+	case BOOT_DEVICE_NOR:
+		spl_nor_load_image();
+		break;
+#endif
 #ifdef CONFIG_SPL_YMODEM_SUPPORT
 	case BOOT_DEVICE_UART:
 		spl_ymodem_load_image();
diff --git a/common/spl/spl_nor.c b/common/spl/spl_nor.c
new file mode 100644
index 0000000..bf0552f
--- /dev/null
+++ b/common/spl/spl_nor.c
@@ -0,0 +1,68 @@ 
+/*
+ * Copyright (C) 2012 Stefan Roese <sr@denx.de>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+ * GNU General Public License for more details.
+ */
+
+#include <common.h>
+#include <spl.h>
+
+/*
+ * Don't use the special MPC5xxx memcpy implementation, only use
+ * the standard one.
+ */
+#if defined(CONFIG_MPC512X) || defined(CONFIG_MPC5200)
+extern void *__memcpy(void *, const void *, size_t);
+#define memcpy		__memcpy
+#endif
+
+void spl_nor_load_image(void)
+{
+	if (spl_start_uboot()) {
+		/*
+		 * Load real U-Boot from its location in NOR flash to its
+		 * defined location in SDRAM
+		 */
+		memcpy((void *)CONFIG_SYS_TEXT_BASE,
+		       (void *)CONFIG_SYS_UBOOT_BASE,
+		       CONFIG_SYS_MONITOR_LEN);
+
+		/*
+		 * This parsing is needed for the SPL framework to correctly
+		 * detect and boot the U-Boot image
+		 */
+		spl_parse_image_header(
+			(const struct image_header *)CONFIG_SYS_TEXT_BASE);
+	} else {
+		/*
+		 * Load Linux from its location in NOR flash to its defined
+		 * location in SDRAM
+		 */
+		spl_parse_image_header(
+			(const struct image_header *)CONFIG_SYS_OS_BASE);
+
+		memcpy((void *)spl_image.load_addr,
+		       (void *)(CONFIG_SYS_OS_BASE +
+				sizeof(struct image_header)),
+		       spl_image.size);
+
+		/*
+		 * Copy DT blob (fdt) to SDRAM. Passing pointer to flash
+		 * doesn't work (16 KiB should be enough for DT)
+		 */
+		memcpy((void *)CONFIG_SYS_SPL_ARGS_ADDR,
+		       (void *)(CONFIG_SYS_FDT_BASE),
+		       (16 << 10));
+	}
+}
diff --git a/include/spl.h b/include/spl.h
index 3b3051f..efa160e 100644
--- a/include/spl.h
+++ b/include/spl.h
@@ -55,6 +55,9 @@  void spl_display_print(void);
 /* NAND SPL functions */
 void spl_nand_load_image(void);
 
+/* NOR SPL functions */
+void spl_nor_load_image(void);
+
 /* MMC SPL functions */
 void spl_mmc_load_image(void);