| Message ID | 1333122599-20805-1-git-send-email-tim.gardner@canonical.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Mar 30, 2012 at 09:49:59AM -0600, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/969309 > > OK. Then, I think we also want to fix these warnings probably introduced by > commit a6021559 "UBUNTU: SAUCE: (no-up) Modularize vesafb". > > WARNING: drivers/video/vesafb.o(.exit.text+0x42): Section mismatch in reference from the function vesafb_remove() to the (unknown reference) .init.data:(unknown) > The function __exit vesafb_remove() references > a (unknown reference) __initdata (unknown). > This is often seen when error handling in the exit function > uses functionality in the init path. > The fix is often to remove the __initdata annotation of > (unknown) so it may be used outside an init section. > > WARNING: drivers/video/vesafb.o(.exit.text+0x4a): Section mismatch in reference from the function vesafb_remove() to the variable .init.data:vesafb_fix > The function __exit vesafb_remove() references > a variable __initdata vesafb_fix. > This is often seen when error handling in the exit function > uses functionality in the init path. > The fix is often to remove the __initdata annotation of > vesafb_fix so it may be used outside an init section. > > Reported-by: Tetsuo Honda <from-ubuntu@I-love.SAKURA.ne.jp> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Ack for all the 3 patches (oneiric, natty, lucid), but shouldn't this also be marked as (no-up) in the commit title? > --- > drivers/video/vesafb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c > index 9d6995d..eb78a59 100644 > --- a/drivers/video/vesafb.c > +++ b/drivers/video/vesafb.c > @@ -46,7 +46,7 @@ static struct fb_var_screeninfo vesafb_defined __initdata = { > .vmode = FB_VMODE_NONINTERLACED, > }; > > -static struct fb_fix_screeninfo vesafb_fix __initdata = { > +static struct fb_fix_screeninfo vesafb_fix = { > .id = "VESA VGA", > .type = FB_TYPE_PACKED_PIXELS, > .accel = FB_ACCEL_NONE, > -- > 1.7.9.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >
On 30.03.2012 17:49, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/969309 > > OK. Then, I think we also want to fix these warnings probably introduced by > commit a6021559 "UBUNTU: SAUCE: (no-up) Modularize vesafb". > > WARNING: drivers/video/vesafb.o(.exit.text+0x42): Section mismatch in reference from the function vesafb_remove() to the (unknown reference) .init.data:(unknown) > The function __exit vesafb_remove() references > a (unknown reference) __initdata (unknown). > This is often seen when error handling in the exit function > uses functionality in the init path. > The fix is often to remove the __initdata annotation of > (unknown) so it may be used outside an init section. > > WARNING: drivers/video/vesafb.o(.exit.text+0x4a): Section mismatch in reference from the function vesafb_remove() to the variable .init.data:vesafb_fix > The function __exit vesafb_remove() references > a variable __initdata vesafb_fix. > This is often seen when error handling in the exit function > uses functionality in the init path. > The fix is often to remove the __initdata annotation of > vesafb_fix so it may be used outside an init section. > > Reported-by: Tetsuo Honda <from-ubuntu@I-love.SAKURA.ne.jp> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > --- > drivers/video/vesafb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c > index 9d6995d..eb78a59 100644 > --- a/drivers/video/vesafb.c > +++ b/drivers/video/vesafb.c > @@ -46,7 +46,7 @@ static struct fb_var_screeninfo vesafb_defined __initdata = { > .vmode = FB_VMODE_NONINTERLACED, > }; > > -static struct fb_fix_screeninfo vesafb_fix __initdata = { > +static struct fb_fix_screeninfo vesafb_fix = { > .id = "VESA VGA", > .type = FB_TYPE_PACKED_PIXELS, > .accel = FB_ACCEL_NONE,
On 30/03/12 16:49, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/969309 > > OK. Then, I think we also want to fix these warnings probably introduced by > commit a6021559 "UBUNTU: SAUCE: (no-up) Modularize vesafb". > > WARNING: drivers/video/vesafb.o(.exit.text+0x42): Section mismatch in reference from the function vesafb_remove() to the (unknown reference) .init.data:(unknown) > The function __exit vesafb_remove() references > a (unknown reference) __initdata (unknown). > This is often seen when error handling in the exit function > uses functionality in the init path. > The fix is often to remove the __initdata annotation of > (unknown) so it may be used outside an init section. > > WARNING: drivers/video/vesafb.o(.exit.text+0x4a): Section mismatch in reference from the function vesafb_remove() to the variable .init.data:vesafb_fix > The function __exit vesafb_remove() references > a variable __initdata vesafb_fix. > This is often seen when error handling in the exit function > uses functionality in the init path. > The fix is often to remove the __initdata annotation of > vesafb_fix so it may be used outside an init section. > > Reported-by: Tetsuo Honda<from-ubuntu@I-love.SAKURA.ne.jp> > Signed-off-by: Tim Gardner<tim.gardner@canonical.com> > --- > drivers/video/vesafb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c > index 9d6995d..eb78a59 100644 > --- a/drivers/video/vesafb.c > +++ b/drivers/video/vesafb.c > @@ -46,7 +46,7 @@ static struct fb_var_screeninfo vesafb_defined __initdata = { > .vmode = FB_VMODE_NONINTERLACED, > }; > > -static struct fb_fix_screeninfo vesafb_fix __initdata = { > +static struct fb_fix_screeninfo vesafb_fix = { > .id = "VESA VGA", > .type = FB_TYPE_PACKED_PIXELS, > .accel = FB_ACCEL_NONE,
Applied to Oneiric. -apw
On Fri, Mar 30, 2012 at 04:39:07PM -0300, Herton Ronaldo Krzesinski wrote: > Ack for all the 3 patches (oneiric, natty, lucid), but shouldn't this > also be marked as (no-up) in the commit title? As the patch they are fixing is (no-up) yes, I presume in Precise we will squash it into the original patch anyhow. Applied with this modification in all cases. -apw
diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c index 9d6995d..eb78a59 100644 --- a/drivers/video/vesafb.c +++ b/drivers/video/vesafb.c @@ -46,7 +46,7 @@ static struct fb_var_screeninfo vesafb_defined __initdata = { .vmode = FB_VMODE_NONINTERLACED, }; -static struct fb_fix_screeninfo vesafb_fix __initdata = { +static struct fb_fix_screeninfo vesafb_fix = { .id = "VESA VGA", .type = FB_TYPE_PACKED_PIXELS, .accel = FB_ACCEL_NONE,
BugLink: http://bugs.launchpad.net/bugs/969309 OK. Then, I think we also want to fix these warnings probably introduced by commit a6021559 "UBUNTU: SAUCE: (no-up) Modularize vesafb". WARNING: drivers/video/vesafb.o(.exit.text+0x42): Section mismatch in reference from the function vesafb_remove() to the (unknown reference) .init.data:(unknown) The function __exit vesafb_remove() references a (unknown reference) __initdata (unknown). This is often seen when error handling in the exit function uses functionality in the init path. The fix is often to remove the __initdata annotation of (unknown) so it may be used outside an init section. WARNING: drivers/video/vesafb.o(.exit.text+0x4a): Section mismatch in reference from the function vesafb_remove() to the variable .init.data:vesafb_fix The function __exit vesafb_remove() references a variable __initdata vesafb_fix. This is often seen when error handling in the exit function uses functionality in the init path. The fix is often to remove the __initdata annotation of vesafb_fix so it may be used outside an init section. Reported-by: Tetsuo Honda <from-ubuntu@I-love.SAKURA.ne.jp> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> --- drivers/video/vesafb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)