diff mbox

[google/main] Check for cross-compilers in validate_failures.py (issue5674087)

Message ID 20120217104933.B888420921@atree.mtv.corp.google.com
State New
Headers show

Commit Message

Doug Kwan (關振德) Feb. 17, 2012, 10:49 a.m. UTC 
Hi Diego,

    This patch fixes a problem of the validate_failures.py script that
it rejects cross compilers.  I have tested it by running the script
in the build directory of gcc configure for arm-unknown-linux-gnueabi.
I also tested it on a native compiler for x86.  This should go to both
google/main and trunk.

-Doug

2012-02-17   Doug Kwan  <dougkwan@google.com>

	* contrib/testsuite-management/validate_failures.py
	(def GetMakefileValue): Check for cross compilers.


--
This patch is available for review at http://codereview.appspot.com/5674087

Comments

Diego Novillo Feb. 17, 2012, 12:52 p.m. UTC | #1 
On 17/02/12 05:49 , Doug Kwan wrote:

> 2012-02-17   Doug Kwan<dougkwan@google.com>
>
> 	* contrib/testsuite-management/validate_failures.py
> 	(def GetMakefileValue): Check for cross compilers.

OK.  Thanks.


Diego.
Doug Kwan (關振德) Feb. 17, 2012, 11:17 p.m. UTC | #2 
Should I submit toe trunk also, now that it is closed?

On Fri, Feb 17, 2012 at 4:52 AM, Diego Novillo <dnovillo@google.com> wrote:
> On 17/02/12 05:49 , Doug Kwan wrote:
>
>> 2012-02-17   Doug Kwan<dougkwan@google.com>
>>
>>        * contrib/testsuite-management/validate_failures.py
>>        (def GetMakefileValue): Check for cross compilers.
>
>
> OK.  Thanks.
>
>
> Diego.
Diego Novillo Feb. 17, 2012, 11:21 p.m. UTC | #3 
On Fri, Feb 17, 2012 at 18:17, Doug Kwan (關振德) <dougkwan@google.com> wrote:
> Should I submit toe trunk also, now that it is closed?

Yes, that's fine.  contrib/ is not release-critical.


Diego.
diff mbox

Patch

Index: contrib/testsuite-management/validate_failures.py
===================================================================
--- contrib/testsuite-management/validate_failures.py	(revision 184327)
+++ contrib/testsuite-management/validate_failures.py	(working copy)
@@ -146,7 +146,8 @@  def GetMakefileValue(makefile_name, value_name):
 def ValidBuildDirectory(builddir, target):
   if (not os.path.exists(builddir) or
       not os.path.exists('%s/Makefile' % builddir) or
-      not os.path.exists('%s/build-%s' % (builddir, target))):
+      (not os.path.exists('%s/build-%s' % (builddir, target)) and
+       not os.path.exists('%s/%s' % (builddir, target)))):
     return False
   return True