From patchwork Fri Feb 17 10:49:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?RG91ZyBLd2FuICjpl5zmjK/lvrcp?= X-Patchwork-Id: 141760 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 992BFB6EF1 for ; Fri, 17 Feb 2012 21:49:54 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1330080595; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: MIME-Version:Received:Received:Received:Received:To:Subject: Message-Id:Date:From:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=xqCQMcF3T3pNlglWjicngMJBflU=; b=uBuwWmszYmhSKkb 7wRjU55FDhF7vJ78WOqRO/IaYyjaQjlZTJjQ7m8UKrZ9NJs+z4aO4oLYlxC9DEOV +J3OrEd0CE7xgdaHGWnrtJ20Zud7V4tw7LVs6cZO35NMZfv/LQISDyY1LmyeiItC VQp8Cur3H5SPE7DFvJp81pov0eLE= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:MIME-Version:Received:Received:Received:Received:To:Subject:Message-Id:Date:From:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Wrq8XGKROVxQnxTdHXlxF0mfh9pDes6lgG57DkCs0OibbnBH51NtAtX28J+i2o FV0+luAkRugxzlJG8UQIvmXdOTmYwQ4ZDMO1XNifn3WfGrFrum9E7tPtZ8aOMwtT WJlVUQr3oLresCu5XodHx+jq21Zo+1hDImfYZU/YeLa8A=; Received: (qmail 14561 invoked by alias); 17 Feb 2012 10:49:50 -0000 Received: (qmail 14550 invoked by uid 22791); 17 Feb 2012 10:49:49 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ee0-f73.google.com (HELO mail-ee0-f73.google.com) (74.125.83.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Feb 2012 10:49:36 +0000 Received: by eekb57 with SMTP id b57so109133eek.2 for ; Fri, 17 Feb 2012 02:49:34 -0800 (PST) Received: by 10.14.99.143 with SMTP id x15mr2387324eef.0.1329475774852; Fri, 17 Feb 2012 02:49:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.14.99.143 with SMTP id x15mr2387312eef.0.1329475774737; Fri, 17 Feb 2012 02:49:34 -0800 (PST) Received: from hpza10.eem.corp.google.com ([74.125.121.33]) by gmr-mx.google.com with ESMTPS id s3si1622068eem.3.2012.02.17.02.49.34 (version=TLSv1/SSLv3 cipher=AES128-SHA); Fri, 17 Feb 2012 02:49:34 -0800 (PST) Received: from atree.mtv.corp.google.com (atree.mtv.corp.google.com [172.18.110.18]) by hpza10.eem.corp.google.com (Postfix) with ESMTP id 86A8E20004E; Fri, 17 Feb 2012 02:49:34 -0800 (PST) Received: by atree.mtv.corp.google.com (Postfix, from userid 51281) id B888420921; Fri, 17 Feb 2012 02:49:33 -0800 (PST) To: reply@codereview.appspotmail.com, dnovillo@google.com, gcc-patches@gcc.gnu.org Subject: [google/main] Check for cross-compilers in validate_failures.py (issue5674087) Message-Id: <20120217104933.B888420921@atree.mtv.corp.google.com> Date: Fri, 17 Feb 2012 02:49:33 -0800 (PST) From: dougkwan@google.com (Doug Kwan) X-Gm-Message-State: ALoCoQlN47MuIbXgtIONuHe+7aU0tT6SKthphD1qVl4CtlpKa5zY3FTjmLy7pWHRO7coeXw1aASzEClKtkNA1ZbIi4sKI+MxTqhEzdSvIjTUv/qm8b7R7V1KkRK0ETOtDLmZ/fqA0zuag/eiROmgs22xx9uIZY88RDIRZmLQ1EFosOy6jMsLriI= X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi Diego, This patch fixes a problem of the validate_failures.py script that it rejects cross compilers. I have tested it by running the script in the build directory of gcc configure for arm-unknown-linux-gnueabi. I also tested it on a native compiler for x86. This should go to both google/main and trunk. -Doug 2012-02-17 Doug Kwan * contrib/testsuite-management/validate_failures.py (def GetMakefileValue): Check for cross compilers. --- This patch is available for review at http://codereview.appspot.com/5674087 Index: contrib/testsuite-management/validate_failures.py =================================================================== --- contrib/testsuite-management/validate_failures.py (revision 184327) +++ contrib/testsuite-management/validate_failures.py (working copy) @@ -146,7 +146,8 @@ def GetMakefileValue(makefile_name, value_name): def ValidBuildDirectory(builddir, target): if (not os.path.exists(builddir) or not os.path.exists('%s/Makefile' % builddir) or - not os.path.exists('%s/build-%s' % (builddir, target))): + (not os.path.exists('%s/build-%s' % (builddir, target)) and + not os.path.exists('%s/%s' % (builddir, target)))): return False return True