| Message ID | 1321523302-4761-1-git-send-email-thierry.reding@avionic-design.de |
|---|---|
| State | Accepted |
| Headers | show |
Thierry Reding wrote at Thursday, November 17, 2011 2:48 AM: > Since Ventana is derived from Seaboard and requires seaboard.c to build, > make sure board/nvidia/seaboard is created in the build tree. > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> Acked-by: Stephen Warren <swarren@nvidia.com> Tested-by: Stephen Warren <swarren@nvidia.com>
On Thursday 17 November 2011 04:48:22 Thierry Reding wrote: > Since Ventana is derived from Seaboard and requires seaboard.c to build, > make sure board/nvidia/seaboard is created in the build tree. > > --- a/board/nvidia/ventana/Makefile > +++ b/board/nvidia/ventana/Makefile > > ifneq ($(OBJTREE),$(SRCTREE)) > +$(shell mkdir -p $(obj)../seaboard) > $(shell mkdir -p $(obj)../common) > endif mkdir takes multiple paths. thus my proposal: -$(shell mkdir -p $(obj)../common) +$(shell mkdir -p $(obj)../common $(obj)../seaboard) -mike
* Mike Frysinger wrote: > On Thursday 17 November 2011 04:48:22 Thierry Reding wrote: > > Since Ventana is derived from Seaboard and requires seaboard.c to build, > > make sure board/nvidia/seaboard is created in the build tree. > > > > --- a/board/nvidia/ventana/Makefile > > +++ b/board/nvidia/ventana/Makefile > > > > ifneq ($(OBJTREE),$(SRCTREE)) > > +$(shell mkdir -p $(obj)../seaboard) > > $(shell mkdir -p $(obj)../common) > > endif > > mkdir takes multiple paths. thus my proposal: > -$(shell mkdir -p $(obj)../common) > +$(shell mkdir -p $(obj)../common $(obj)../seaboard) > -mike Heh, right. =) Thierry
Dear Thierry Reding, In message <1321523302-4761-1-git-send-email-thierry.reding@avionic-design.de> you wrote: > Since Ventana is derived from Seaboard and requires seaboard.c to build, > make sure board/nvidia/seaboard is created in the build tree. > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> > --- > board/nvidia/ventana/Makefile | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Verified that this indeed fixes the Ventana OOT build issues. Thanks. Tested-by: Wolfgang Denk <wd@denx.de> Best regards, Wolfgang Denk
Dear Thierry Reding, In message <1321523302-4761-1-git-send-email-thierry.reding@avionic-design.de> you wrote: > Since Ventana is derived from Seaboard and requires seaboard.c to build, > make sure board/nvidia/seaboard is created in the build tree. > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> > --- > board/nvidia/ventana/Makefile | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
* Wolfgang Denk wrote: > Dear Thierry Reding, > > In message <1321523302-4761-1-git-send-email-thierry.reding@avionic-design.de> you wrote: > > Since Ventana is derived from Seaboard and requires seaboard.c to build, > > make sure board/nvidia/seaboard is created in the build tree. > > > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> > > --- > > board/nvidia/ventana/Makefile | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > Applied, thanks. I actually have an updated version applied locally with the change proposed by Mike, but I completely forgot to send it to the list. Thierry
Dear Thierry Reding, In message <20111222090337.GA844@avionic-0098.mockup.avionic-design.de> you wrote: > > I actually have an updated version applied locally with the change proposed > by Mike, but I completely forgot to send it to the list. Can you then please submit an incremental patch (against current master)? TIA... Best regards, Wolfgang Denk
diff --git a/board/nvidia/ventana/Makefile b/board/nvidia/ventana/Makefile index 9e5a87f..d5140c8 100644 --- a/board/nvidia/ventana/Makefile +++ b/board/nvidia/ventana/Makefile @@ -25,6 +25,7 @@ include $(TOPDIR)/config.mk ifneq ($(OBJTREE),$(SRCTREE)) +$(shell mkdir -p $(obj)../seaboard) $(shell mkdir -p $(obj)../common) endif
Since Ventana is derived from Seaboard and requires seaboard.c to build, make sure board/nvidia/seaboard is created in the build tree. Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> --- board/nvidia/ventana/Makefile | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)