| Message ID | 20200424085839.60284-2-wenhu.wang@vivo.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/5] powerpc: sysdev: fix compile error for fsl_85xx_l2ctlr | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (47e80b4d8b45ae1bd3a1fe8577e95571cb8a976e) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| snowpatch_ozlabs/needsstable | warning | Please consider tagging this patch for stable! |
Le 24/04/2020 à 10:58, Wang Wenhu a écrit : > Include "linux/of_address.h" to fix the compile error for > mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c. > > CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function ‘mpc85xx_l2ctlr_of_probe’: > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit declaration of function ‘of_iomap’; did you mean ‘pci_iomap’? [-Werror=implicit-function-declaration] > l2ctlr = of_iomap(dev->dev.of_node, 0); > ^~~~~~~~ > pci_iomap > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] > l2ctlr = of_iomap(dev->dev.of_node, 0); > ^ > cc1: all warnings being treated as errors > scripts/Makefile.build:267: recipe for target 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed > make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1 > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Christophe Leroy <christophe.leroy@c-s.fr> > Cc: Scott Wood <oss@buserror.net> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Randy Dunlap <rdunlap@infradead.org> > Cc: linuxppc-dev@lists.ozlabs.org > Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support") > Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr> > Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com> Is there still an interest for this series ? I see there is even a v5 at https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=172421&state=* allthough I can't find it in my emails. If so do you plan to send any update of it at some point ? Otherwise, as CONFIG_FSL_85XX_CACHE_SRAM is not user selectable and no driver selects it, I think time has come to remove it completely. Thanks Christophe > --- > No change v1-v4 > --- > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c > index 2d0af0c517bb..7533572492f0 100644 > --- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c > +++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c > @@ -10,6 +10,7 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/of_platform.h> > +#include <linux/of_address.h> > #include <asm/io.h> > > #include "fsl_85xx_cache_ctlr.h"
Le 15/03/2022 à 13:45, Christophe Leroy a écrit : > > > Le 24/04/2020 à 10:58, Wang Wenhu a écrit : >> Include "linux/of_address.h" to fix the compile error for >> mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c. >> >> CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o >> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function >> ‘mpc85xx_l2ctlr_of_probe’: >> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit >> declaration of function ‘of_iomap’; did you mean ‘pci_iomap’? >> [-Werror=implicit-function-declaration] >> l2ctlr = of_iomap(dev->dev.of_node, 0); >> ^~~~~~~~ >> pci_iomap >> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes >> pointer from integer without a cast [-Werror=int-conversion] >> l2ctlr = of_iomap(dev->dev.of_node, 0); >> ^ >> cc1: all warnings being treated as errors >> scripts/Makefile.build:267: recipe for target >> 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed >> make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1 >> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: Arnd Bergmann <arnd@arndb.de> >> Cc: Christophe Leroy <christophe.leroy@c-s.fr> >> Cc: Scott Wood <oss@buserror.net> >> Cc: Michael Ellerman <mpe@ellerman.id.au> >> Cc: Randy Dunlap <rdunlap@infradead.org> >> Cc: linuxppc-dev@lists.ozlabs.org >> Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support") >> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr> >> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com> > > Is there still an interest for this series ? > > I see there is even a v5 at > https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=172421&state=* > allthough I can't find it in my emails. > > If so do you plan to send any update of it at some point ? > > Otherwise, as CONFIG_FSL_85XX_CACHE_SRAM is not user selectable and no > driver selects it, I think time has come to remove it completely. > CONFIG_FSL_85XX_CACHE_SRAM has now been removed. See https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=dc21ed2aef4150fc2fcf58227a4ff24502015c03
diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c index 2d0af0c517bb..7533572492f0 100644 --- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c +++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c @@ -10,6 +10,7 @@ #include <linux/kernel.h> #include <linux/module.h> #include <linux/of_platform.h> +#include <linux/of_address.h> #include <asm/io.h> #include "fsl_85xx_cache_ctlr.h"
Include "linux/of_address.h" to fix the compile error for mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c. CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function ‘mpc85xx_l2ctlr_of_probe’: arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit declaration of function ‘of_iomap’; did you mean ‘pci_iomap’? [-Werror=implicit-function-declaration] l2ctlr = of_iomap(dev->dev.of_node, 0); ^~~~~~~~ pci_iomap arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] l2ctlr = of_iomap(dev->dev.of_node, 0); ^ cc1: all warnings being treated as errors scripts/Makefile.build:267: recipe for target 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1 Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Christophe Leroy <christophe.leroy@c-s.fr> Cc: Scott Wood <oss@buserror.net> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: linuxppc-dev@lists.ozlabs.org Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support") Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com> --- No change v1-v4 --- arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 1 + 1 file changed, 1 insertion(+)