| Message ID | 1318418018-28462-1-git-send-email-hs@denx.de |
|---|---|
| State | Accepted |
| Commit | ee4014b0053a5d56c3b6d7d0da56ad9ceb011efc |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
On Wednesday 12 October 2011 07:13:38 Heiko Schocher wrote: > --- a/arch/arm/lib/board.c > +++ b/arch/arm/lib/board.c > @@ -80,7 +80,6 @@ extern void rtl8019_get_enetaddr (uchar * addr); > #include <i2c.h> > #endif > > - > /************************************************************************ > * Coloured LED functionality > ************************************************************************ this looks like useless noise that checkpatch doesn't even complain about > --- a/common/cmd_log.c > +++ b/common/cmd_log.c > > unsigned long __logbuffer_base(void) > { > - return CONFIG_SYS_SDRAM_BASE + gd->bd->bi_memsize - LOGBUFF_LEN; > + return CONFIG_SYS_SDRAM_BASE + gd->ram_size - LOGBUFF_LEN; > } i'm guessing avr32/microblaze not having ram_size in their global_data is a bug ? conversely, arm is the only arch that doesn't have bi_memsize in their board_data ... -mike
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 705d4d2..b1974bf 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -80,7 +80,6 @@ extern void rtl8019_get_enetaddr (uchar * addr); #include <i2c.h> #endif - /************************************************************************ * Coloured LED functionality ************************************************************************ diff --git a/common/cmd_log.c b/common/cmd_log.c index 0e89357..249614f 100644 --- a/common/cmd_log.c +++ b/common/cmd_log.c @@ -68,7 +68,7 @@ static char *lbuf; unsigned long __logbuffer_base(void) { - return CONFIG_SYS_SDRAM_BASE + gd->bd->bi_memsize - LOGBUFF_LEN; + return CONFIG_SYS_SDRAM_BASE + gd->ram_size - LOGBUFF_LEN; } unsigned long logbuffer_base (void) __attribute__((weak, alias("__logbuffer_base")));
Signed-off-by: Heiko Schocher <hs@denx.de> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net> --- - changes for v2: - rebased against current TOT checkpatch: total: 0 errors, 0 warnings, 15 lines checked 0001-arm-logbuffer-make-it-compileclean.patch has no obvious style problems and is ready for submission. arch/arm/lib/board.c | 1 - common/cmd_log.c | 2 +- 2 files changed, 1 insertions(+), 2 deletions(-)