| Message ID | 20210301182307.1681548-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: Return -EINVAL for old-style drivers without .set_polarity callback | expand |
On Mon, Mar 01, 2021 at 07:23:07PM +0100, Uwe Kleine-König wrote: > Since commit 2b1c1a5d5148 ("pwm: Use -EINVAL for unsupported polarity") > all drivers implementing the apply callback are unified to return > -EINVAL if an unsupported polarity is requested. Do the same in the > compat code for old-style drivers. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/pwm/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thierry
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index a8eff4b3ee36..8e1f97f2e049 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -607,7 +607,7 @@ int pwm_apply_state(struct pwm_device *pwm, const struct pwm_state *state) */ if (state->polarity != pwm->state.polarity) { if (!chip->ops->set_polarity) - return -ENOTSUPP; + return -EINVAL; /* * Changing the polarity of a running PWM is
Since commit 2b1c1a5d5148 ("pwm: Use -EINVAL for unsupported polarity") all drivers implementing the apply callback are unified to return -EINVAL if an unsupported polarity is requested. Do the same in the compat code for old-style drivers. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)