| Message ID | 1314719460-27858-1-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted, archived |
| Commit | 019fd6d45b611193610e3366392c53a817c3cee2 |
| Delegated to: | Wolfgang Denk |
| Headers | show |
On Aug 30, 2011, at 10:51 AM, Simon Glass wrote: > This fixes "Warning: failed to set MAC address" on platforms which rely on > an 'ethaddr' environment variable to set the MAC address. > > This bug was introduced by this commit: > > 7616e785 Add Ethernet hardware MAC address framework to usbnet > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > net/eth.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Tested-by: Kumar Gala <galak@kernel.crashing.org> (for SoC based ethernet) - k
Kumar Gala wrote: > On Aug 30, 2011, at 10:51 AM, Simon Glass wrote: > >> This fixes "Warning: failed to set MAC address" on platforms which rely on >> an 'ethaddr' environment variable to set the MAC address. >> >> This bug was introduced by this commit: >> >> 7616e785 Add Ethernet hardware MAC address framework to usbnet >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> net/eth.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > Tested-by: Kumar Gala <galak@kernel.crashing.org> I have made similar patch. Tested-by: Michal Simek <monstr@monstr.eu> Thanks, Michal
Hello Simon, Simon Glass wrote: > This fixes "Warning: failed to set MAC address" on platforms which rely on > an 'ethaddr' environment variable to set the MAC address. > > This bug was introduced by this commit: > > 7616e785 Add Ethernet hardware MAC address framework to usbnet > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > net/eth.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Tested on a davinci am1808 based board, so Tested-by: Heiko Schocher <hs@denx.de> Thanks for fixing this! bye, Heiko
Dear Simon Glass, In message <1314719460-27858-1-git-send-email-sjg@chromium.org> you wrote: > This fixes "Warning: failed to set MAC address" on platforms which rely on > an 'ethaddr' environment variable to set the MAC address. > > This bug was introduced by this commit: > > 7616e785 Add Ethernet hardware MAC address framework to usbnet > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > net/eth.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
diff --git a/net/eth.c b/net/eth.c index a34fe59..2caaf60 100644 --- a/net/eth.c +++ b/net/eth.c @@ -296,7 +296,7 @@ int eth_initialize(bd_t *bis) if (strchr(dev->name, ' ')) puts("\nWarning: eth device name has a space!\n"); - if (eth_write_hwaddr(dev, NULL, eth_number)) + if (eth_write_hwaddr(dev, "eth", eth_number)) puts("Warning: failed to set MAC address\n"); eth_number++;
This fixes "Warning: failed to set MAC address" on platforms which rely on an 'ethaddr' environment variable to set the MAC address. This bug was introduced by this commit: 7616e785 Add Ethernet hardware MAC address framework to usbnet Signed-off-by: Simon Glass <sjg@chromium.org> --- net/eth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)