| Message ID | 201108261741.38560.marek.vasut@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
Dear Marek Vasut, In message <201108261741.38560.marek.vasut@gmail.com> you wrote: > > This one can be fixed with such a patch, though I dunno if it's worth it. If you are sure that this is sufficient, then could you please submit a proper patch with Subject, SoB-Line, etc.? Rowel, can you please confirm that this patch works for you, too? Thanks. Best regards, Wolfgang Denk
On Friday, August 26, 2011 09:57:15 PM Wolfgang Denk wrote: > Dear Marek Vasut, > > In message <201108261741.38560.marek.vasut@gmail.com> you wrote: > > This one can be fixed with such a patch, though I dunno if it's worth it. > > If you are sure that this is sufficient, then could you please submit > a proper patch with Subject, SoB-Line, etc.? > Ok, what I meant by "dunno if it's worth it" is, whether we do or don't want to prolong the agony of this board. Noone maintains it anymore, it's basically a dead code. Do we want to keep it? Correct me if I'm wrong. Cheers > > Rowel, can you please confirm that this patch works for you, too? > > > Thanks. > > Best regards, > > Wolfgang Denk
Dear Marek Vasut, In message <201108262249.13179.marek.vasut@gmail.com> you wrote: > > > If you are sure that this is sufficient, then could you please submit > > a proper patch with Subject, SoB-Line, etc.? > > > Ok, what I meant by "dunno if it's worth it" is, whether we do or don't want to > prolong the agony of this board. Noone maintains it anymore, it's basically a > dead code. Do we want to keep it? Correct me if I'm wrong. Well, let's see if Rowel wakes up now. Best regards, Wolfgang Denk
Hi Marek, > This one can be fixed with such a patch, though I dunno if it's worth it. > > diff --git a/include/configs/armadillo.h b/include/configs/armadillo.h > [...] I have seen the rest of the discussion already, and will apply the armadillo removal patch. I just want to make a quick note (again) to all: Please avoid copy-pasting a patch or even part of a patch in your replies to an official patch, because patchwork then believes you have actually posted a new patch and created a new entry, "hijacking" the comments for the original one. The 'armadillo' patch shows the issue: <http://patchwork.ozlabs.org/patch/111747/> is the actual patch which should have had the comments, but these were 'hijacked' and stored under <http://patchwork.ozlabs.org/patch/111800/> which is actually not a patch but one of the replies. Amicalement,
On Tuesday, August 30, 2011 08:06:43 AM Albert ARIBAUD wrote: > Hi Marek, > > > This one can be fixed with such a patch, though I dunno if it's worth it. > > > > diff --git a/include/configs/armadillo.h b/include/configs/armadillo.h > > [...] > > I have seen the rest of the discussion already, and will apply the > armadillo removal patch. I just want to make a quick note (again) to all: Yes, it seems the person maintaining Armadillo doesn't respond. Even worse, that mailbox is long abandoned. > > Please avoid copy-pasting a patch or even part of a patch in your > replies to an official patch, because patchwork then believes you have > actually posted a new patch and created a new entry, "hijacking" the > comments for the original one. Ah damn, ok. > > The 'armadillo' patch shows the issue: > > <http://patchwork.ozlabs.org/patch/111747/> is the actual patch which > should have had the comments, but these were 'hijacked' and stored under > <http://patchwork.ozlabs.org/patch/111800/> which is actually not a > patch but one of the replies. > > Amicalement, Cheers
Dear Albert ARIBAUD, In message <4E5C7DF3.3090506@aribaud.net> you wrote: > Hi Marek, > > > This one can be fixed with such a patch, though I dunno if it's worth it. > > > > diff --git a/include/configs/armadillo.h b/include/configs/armadillo.h > > [...] > > I have seen the rest of the discussion already, and will apply the > armadillo removal patch. I just want to make a quick note (again) to all: Yes, please remove the board. All attempts to contect the currently known maintainer address failed. Best regards, Wolfgang Denk
diff --git a/include/configs/armadillo.h b/include/configs/armadillo.h index d0d0998..8a2d2b7 100644 --- a/include/configs/armadillo.h +++ b/include/configs/armadillo.h @@ -135,6 +135,8 @@ #define PHYS_FLASH_SIZE 0x00400000 /* 4 MB */ #define CONFIG_SYS_FLASH_BASE PHYS_FLASH_1 +#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1 +#define CONFIG_SYS_INIT_SP_ADDR (PHYS_SDRAM_1 + CONFIG_STACKSIZE) /*----------------------------------------------------------------------- * FLASH and environment organization