| Message ID | 20201214205905.888432-1-mail@aparcar.org |
|---|---|
| State | Rejected |
| Delegated to: | Paul Spooren |
| Headers | show |
| Series | mvebu/cortexa53: add targz rootfs feature | expand |
On 14. 12. 20 21:59, Paul Spooren wrote: > The rootfs is required to create rootfs Docker containers. With this > feature enable a new runtime test can happen for the aarch64_cortex-a53 > architecture. > > CC: Josef Schlehofer <pepe.schlehofer@gmail.com> > Signed-off-by: Paul Spooren <mail@aparcar.org> Acked-by: Josef Schlehofer <pepe.schlehofer@gmail.com> > --- > target/linux/mvebu/cortexa53/target.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/linux/mvebu/cortexa53/target.mk b/target/linux/mvebu/cortexa53/target.mk > index fe89d08ffa..10080c0b8f 100644 > --- a/target/linux/mvebu/cortexa53/target.mk > +++ b/target/linux/mvebu/cortexa53/target.mk > @@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk > ARCH:=aarch64 > BOARDNAME:=Marvell Armada 3700LP (ARM64) > CPU_TYPE:=cortex-a53 > -FEATURES+=ext4 > +FEATURES+=ext4 targz > DEFAULT_PACKAGES+=e2fsprogs ethtool mkf2fs partx-utils > > KERNELNAME:=Image dtbs
On Mon, Dec 14, 2020 at 10:10:32PM +0100, Josef Schlehofer wrote: > > On 14. 12. 20 21:59, Paul Spooren wrote: > > The rootfs is required to create rootfs Docker containers. With this > > feature enable a new runtime test can happen for the aarch64_cortex-a53 > > architecture. > > > > CC: Josef Schlehofer <pepe.schlehofer@gmail.com> > > Signed-off-by: Paul Spooren <mail@aparcar.org> > Acked-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Erm, NACK. Why add this to a random target? Wouldn't it be smarter to use the rootfs of armvirt/32 instead? > > --- > > target/linux/mvebu/cortexa53/target.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/target/linux/mvebu/cortexa53/target.mk b/target/linux/mvebu/cortexa53/target.mk > > index fe89d08ffa..10080c0b8f 100644 > > --- a/target/linux/mvebu/cortexa53/target.mk > > +++ b/target/linux/mvebu/cortexa53/target.mk > > @@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk > > ARCH:=aarch64 > > BOARDNAME:=Marvell Armada 3700LP (ARM64) > > CPU_TYPE:=cortex-a53 > > -FEATURES+=ext4 > > +FEATURES+=ext4 targz > > DEFAULT_PACKAGES+=e2fsprogs ethtool mkf2fs partx-utils > > > > KERNELNAME:=Image dtbs > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
On Mo, Dez 14, 2020 at 21:22, Daniel Golle <daniel@makrotopia.org> wrote: > On Mon, Dec 14, 2020 at 10:10:32PM +0100, Josef Schlehofer wrote: >> >> On 14. 12. 20 21:59, Paul Spooren wrote: >> > The rootfs is required to create rootfs Docker containers. With >> this >> > feature enable a new runtime test can happen for the >> aarch64_cortex-a53 >> > architecture. >> > >> > CC: Josef Schlehofer <pepe.schlehofer@gmail.com> >> > Signed-off-by: Paul Spooren <mail@aparcar.org> >> Acked-by: Josef Schlehofer <pepe.schlehofer@gmail.com> > > Erm, NACK. Why add this to a random target? Wouldn't it be smarter to > use the rootfs of armvirt/32 instead? Good point, I prefer the change of armvirt/64[1] instead of adding mvebu. [1]: https://patchwork.ozlabs.org/project/openwrt/patch/20201213140237.3137718-1-pepe.schlehofer@gmail.com/ > >> > --- >> > target/linux/mvebu/cortexa53/target.mk | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/target/linux/mvebu/cortexa53/target.mk >> b/target/linux/mvebu/cortexa53/target.mk >> > index fe89d08ffa..10080c0b8f 100644 >> > --- a/target/linux/mvebu/cortexa53/target.mk >> > +++ b/target/linux/mvebu/cortexa53/target.mk >> > @@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk >> > ARCH:=aarch64 >> > BOARDNAME:=Marvell Armada 3700LP (ARM64) >> > CPU_TYPE:=cortex-a53 >> > -FEATURES+=ext4 >> > +FEATURES+=ext4 targz >> > DEFAULT_PACKAGES+=e2fsprogs ethtool mkf2fs partx-utils >> > >> > KERNELNAME:=Image dtbs >> > > > >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel >
diff --git a/target/linux/mvebu/cortexa53/target.mk b/target/linux/mvebu/cortexa53/target.mk index fe89d08ffa..10080c0b8f 100644 --- a/target/linux/mvebu/cortexa53/target.mk +++ b/target/linux/mvebu/cortexa53/target.mk @@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk ARCH:=aarch64 BOARDNAME:=Marvell Armada 3700LP (ARM64) CPU_TYPE:=cortex-a53 -FEATURES+=ext4 +FEATURES+=ext4 targz DEFAULT_PACKAGES+=e2fsprogs ethtool mkf2fs partx-utils KERNELNAME:=Image dtbs
The rootfs is required to create rootfs Docker containers. With this feature enable a new runtime test can happen for the aarch64_cortex-a53 architecture. CC: Josef Schlehofer <pepe.schlehofer@gmail.com> Signed-off-by: Paul Spooren <mail@aparcar.org> --- target/linux/mvebu/cortexa53/target.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)