| Message ID | 20201109064959.15252-2-po-hsu.lin@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | Enable Rados block device support | expand |
On 09.11.20 07:49, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1902434 > > Enable the rbd (Rados block device) module support for Ceph. > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> I think it makes sense to enable this module, but also to enable it on all kvm kernels for consistency. Adding Stefan to CC as I would like to hear his opinion on this. Thanks. > --- > debian.kvm/config/config.common.ubuntu | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu > index 06626c8..5959890 100644 > --- a/debian.kvm/config/config.common.ubuntu > +++ b/debian.kvm/config/config.common.ubuntu > @@ -240,7 +240,7 @@ CONFIG_BLK_DEV_PMEM=y > CONFIG_BLK_DEV_RAM=m > CONFIG_BLK_DEV_RAM_COUNT=16 > CONFIG_BLK_DEV_RAM_SIZE=65536 > -# CONFIG_BLK_DEV_RBD is not set > +CONFIG_BLK_DEV_RBD=m > # CONFIG_BLK_DEV_RSXX is not set > CONFIG_BLK_DEV_SD=y > # CONFIG_BLK_DEV_SKD is not set >
On 09.11.20 07:49, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1902434 > > Enable the rbd (Rados block device) module support for Ceph. > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- Would it not be sensible to start adding these kind of things to annotations as enforced? -Stefan > debian.kvm/config/config.common.ubuntu | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu > index 06626c8..5959890 100644 > --- a/debian.kvm/config/config.common.ubuntu > +++ b/debian.kvm/config/config.common.ubuntu > @@ -240,7 +240,7 @@ CONFIG_BLK_DEV_PMEM=y > CONFIG_BLK_DEV_RAM=m > CONFIG_BLK_DEV_RAM_COUNT=16 > CONFIG_BLK_DEV_RAM_SIZE=65536 > -# CONFIG_BLK_DEV_RBD is not set > +CONFIG_BLK_DEV_RBD=m > # CONFIG_BLK_DEV_RSXX is not set > CONFIG_BLK_DEV_SD=y > # CONFIG_BLK_DEV_SKD is not set >
On Thu, Nov 12, 2020 at 4:40 PM Stefan Bader <stefan.bader@canonical.com> wrote: > > On 09.11.20 07:49, Po-Hsu Lin wrote: > > BugLink: https://bugs.launchpad.net/bugs/1902434 > > > > Enable the rbd (Rados block device) module support for Ceph. > > > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> > Acked-by: Stefan Bader <stefan.bader@canonical.com> > > --- > > Would it not be sensible to start adding these kind of things to annotations as > enforced? > I am not really familiar with that mark stuff (any article that I can study from?) Do you mean like the following? CONFIG_BLK_DEV_RBD mark<ENFORCED> note<LP:1902434> I can send V2 if needed. Thanks Sam > -Stefan > > > debian.kvm/config/config.common.ubuntu | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu > > index 06626c8..5959890 100644 > > --- a/debian.kvm/config/config.common.ubuntu > > +++ b/debian.kvm/config/config.common.ubuntu > > @@ -240,7 +240,7 @@ CONFIG_BLK_DEV_PMEM=y > > CONFIG_BLK_DEV_RAM=m > > CONFIG_BLK_DEV_RAM_COUNT=16 > > CONFIG_BLK_DEV_RAM_SIZE=65536 > > -# CONFIG_BLK_DEV_RBD is not set > > +CONFIG_BLK_DEV_RBD=m > > # CONFIG_BLK_DEV_RSXX is not set > > CONFIG_BLK_DEV_SD=y > > # CONFIG_BLK_DEV_SKD is not set > > > >
On 12.11.20 09:50, Po-Hsu Lin wrote: > On Thu, Nov 12, 2020 at 4:40 PM Stefan Bader > <stefan.bader@canonical.com> wrote: >> >> On 09.11.20 07:49, Po-Hsu Lin wrote: >>> BugLink: https://bugs.launchpad.net/bugs/1902434 >>> >>> Enable the rbd (Rados block device) module support for Ceph. >>> >>> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> >> Acked-by: Stefan Bader <stefan.bader@canonical.com> >>> --- >> >> Would it not be sensible to start adding these kind of things to annotations as >> enforced? >> > I am not really familiar with that mark stuff (any article that I can > study from?) > Do you mean like the following? > CONFIG_BLK_DEV_RBD mark<ENFORCED> note<LP:1902434> Yes, that, we can add that when we apply the patch. No need to re-submit if you agree that we make that modification. -Stefan > > I can send V2 if needed. > Thanks > Sam > >> -Stefan >> >>> debian.kvm/config/config.common.ubuntu | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu >>> index 06626c8..5959890 100644 >>> --- a/debian.kvm/config/config.common.ubuntu >>> +++ b/debian.kvm/config/config.common.ubuntu >>> @@ -240,7 +240,7 @@ CONFIG_BLK_DEV_PMEM=y >>> CONFIG_BLK_DEV_RAM=m >>> CONFIG_BLK_DEV_RAM_COUNT=16 >>> CONFIG_BLK_DEV_RAM_SIZE=65536 >>> -# CONFIG_BLK_DEV_RBD is not set >>> +CONFIG_BLK_DEV_RBD=m >>> # CONFIG_BLK_DEV_RSXX is not set >>> CONFIG_BLK_DEV_SD=y >>> # CONFIG_BLK_DEV_SKD is not set >>> >> >>
On Thu, Nov 12, 2020 at 5:13 PM Stefan Bader <stefan.bader@canonical.com> wrote: > > On 12.11.20 09:50, Po-Hsu Lin wrote: > > On Thu, Nov 12, 2020 at 4:40 PM Stefan Bader > > <stefan.bader@canonical.com> wrote: > >> > >> On 09.11.20 07:49, Po-Hsu Lin wrote: > >>> BugLink: https://bugs.launchpad.net/bugs/1902434 > >>> > >>> Enable the rbd (Rados block device) module support for Ceph. > >>> > >>> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> > >> Acked-by: Stefan Bader <stefan.bader@canonical.com> > >>> --- > >> > >> Would it not be sensible to start adding these kind of things to annotations as > >> enforced? > >> > > I am not really familiar with that mark stuff (any article that I can > > study from?) > > Do you mean like the following? > > CONFIG_BLK_DEV_RBD mark<ENFORCED> note<LP:1902434> > > Yes, that, we can add that when we apply the patch. No need to re-submit if you > agree that we make that modification. > Oh that would be great, I agree with that modification. Thank you! Sam > -Stefan > > > > > I can send V2 if needed. > > Thanks > > Sam > > > >> -Stefan > >> > >>> debian.kvm/config/config.common.ubuntu | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu > >>> index 06626c8..5959890 100644 > >>> --- a/debian.kvm/config/config.common.ubuntu > >>> +++ b/debian.kvm/config/config.common.ubuntu > >>> @@ -240,7 +240,7 @@ CONFIG_BLK_DEV_PMEM=y > >>> CONFIG_BLK_DEV_RAM=m > >>> CONFIG_BLK_DEV_RAM_COUNT=16 > >>> CONFIG_BLK_DEV_RAM_SIZE=65536 > >>> -# CONFIG_BLK_DEV_RBD is not set > >>> +CONFIG_BLK_DEV_RBD=m > >>> # CONFIG_BLK_DEV_RSXX is not set > >>> CONFIG_BLK_DEV_SD=y > >>> # CONFIG_BLK_DEV_SKD is not set > >>> > >> > >> > >
diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu index 06626c8..5959890 100644 --- a/debian.kvm/config/config.common.ubuntu +++ b/debian.kvm/config/config.common.ubuntu @@ -240,7 +240,7 @@ CONFIG_BLK_DEV_PMEM=y CONFIG_BLK_DEV_RAM=m CONFIG_BLK_DEV_RAM_COUNT=16 CONFIG_BLK_DEV_RAM_SIZE=65536 -# CONFIG_BLK_DEV_RBD is not set +CONFIG_BLK_DEV_RBD=m # CONFIG_BLK_DEV_RSXX is not set CONFIG_BLK_DEV_SD=y # CONFIG_BLK_DEV_SKD is not set
BugLink: https://bugs.launchpad.net/bugs/1902434 Enable the rbd (Rados block device) module support for Ceph. Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> --- debian.kvm/config/config.common.ubuntu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)