| Message ID | 20201030075045.6960-7-etienne.carriere@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/8] configs/qemu_arm_vexpress_tz_defconfig: enable CXX toolchain | expand |
Hello Étienne, On Fri, 30 Oct 2020 08:50:44 +0100 Etienne Carriere <etienne.carriere@linaro.org> wrote: > OPTEE_TEST_DEPENDENCIES = optee-client optee-os > +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y) Is it intentional that the dependency is on BR2_PACKAGE_LIBOPENSSL and not BR2_PACKAGE_OPENSSL ? If you use BR2_PACKAGE_OPENSSL, it means that either openssl or libressl can be used. If you use BR2_PACKAGE_LIBOPENSSL, then it means that you really only support working with openssl. Normally, libressl is a drop-in replacement for openssl, so it does work just like openssl in most cases. There are however a few OpenSSL APIs that are no longer supported in LibreSSL. Could you clarify this point ? Thanks, Thomas
Hello Thomas, On Sat, 31 Oct 2020 at 22:46, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello Étienne, > > On Fri, 30 Oct 2020 08:50:44 +0100 > Etienne Carriere <etienne.carriere@linaro.org> wrote: > > > OPTEE_TEST_DEPENDENCIES = optee-client optee-os > > +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y) > > Is it intentional that the dependency is on BR2_PACKAGE_LIBOPENSSL and > not BR2_PACKAGE_OPENSSL ? > > If you use BR2_PACKAGE_OPENSSL, it means that either openssl or > libressl can be used. If you use BR2_PACKAGE_LIBOPENSSL, then it means > that you really only support working with openssl. > > Normally, libressl is a drop-in replacement for openssl, so it does > work just like openssl in most cases. There are however a few OpenSSL > APIs that are no longer supported in LibreSSL. > > Could you clarify this point ? Thanks for highlighting this. Indeed, constraining to libopenssl was not intentional. I've checked. From my reading, I would think optee-test uses standard stuff from openssl that libressl supports but testing here with libressl makes the optee-test test tool fail on a certificate test. I guess this should be investigated from the optee project scope. As for now I'd rather stick to BR2_PACKAGE_LIBOPENSSL dependency here as this change proposes. Regards, Etienne > > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
Étienne, All, On 2020-10-30 08:50 +0100, Etienne Carriere spake thusly: > Add a dependency on openssl upon BR2_PACKAGE_LIBOPENSSL=y to > enable some for OP-TEE embedded tests. > > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> Applied to next, with the following changes: - match the depenency to libopenssl, since that's is what is used in the condition (BR2_PACKAGE_LIBOPENSSL) - add a blurb to explain why libopenssl is used, not the virutal openssl Thanks! BTW, there are openssl headers and a pre-built libcrypto.a for arm and AArch64 in optee-test 3.12.0. Was that intentional? Regards, Yann E. MORIN. > --- > package/optee-test/optee-test.mk | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/package/optee-test/optee-test.mk b/package/optee-test/optee-test.mk > index 1f4f586672..189956651b 100644 > --- a/package/optee-test/optee-test.mk > +++ b/package/optee-test/optee-test.mk > @@ -10,6 +10,9 @@ OPTEE_TEST_LICENSE = GPL-2.0, BSD-2-Clause, > OPTEE_TEST_LICENSE_FILES = LICENSE.md > > OPTEE_TEST_DEPENDENCIES = optee-client optee-os > +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y) > +OPTEE_TEST_DEPENDENCIES += openssl > +endif > > OPTEE_TEST_CONF_OPTS = -DOPTEE_TEST_SDK=$(OPTEE_OS_SDK) > > -- > 2.17.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi, Jérôme in copy, from the optee_test.git maintainers. On Sun, 7 Mar 2021 at 00:15, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Étienne, All, > > On 2020-10-30 08:50 +0100, Etienne Carriere spake thusly: > > Add a dependency on openssl upon BR2_PACKAGE_LIBOPENSSL=y to > > enable some for OP-TEE embedded tests. > > > > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > > Applied to next, with the following changes: > > - match the depenency to libopenssl, since that's is what is used in > the condition (BR2_PACKAGE_LIBOPENSSL) > - add a blurb to explain why libopenssl is used, not the virutal > openssl > > Thanks! > > BTW, there are openssl headers and a pre-built libcrypto.a for arm and > AArch64 in optee-test 3.12.0. Was that intentional? That's an ugly hack (sorry jérôme) for when build env is missing an openssl. Since the build env proposed in OP-TEE release, maybe we don't need them anymore. Jérôme, do you think we still need the repbuilt openssl libs in optee_test? br, etienne > > Regards, > Yann E. MORIN. > > > --- > > package/optee-test/optee-test.mk | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/package/optee-test/optee-test.mk b/package/optee-test/optee-test.mk > > index 1f4f586672..189956651b 100644 > > --- a/package/optee-test/optee-test.mk > > +++ b/package/optee-test/optee-test.mk > > @@ -10,6 +10,9 @@ OPTEE_TEST_LICENSE = GPL-2.0, BSD-2-Clause, > > OPTEE_TEST_LICENSE_FILES = LICENSE.md > > > > OPTEE_TEST_DEPENDENCIES = optee-client optee-os > > +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y) > > +OPTEE_TEST_DEPENDENCIES += openssl > > +endif > > > > OPTEE_TEST_CONF_OPTS = -DOPTEE_TEST_SDK=$(OPTEE_OS_SDK) > > > > -- > > 2.17.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------'
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > Étienne, All, > On 2020-10-30 08:50 +0100, Etienne Carriere spake thusly: >> Add a dependency on openssl upon BR2_PACKAGE_LIBOPENSSL=y to >> enable some for OP-TEE embedded tests. >> >> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > Applied to next, with the following changes: > - match the depenency to libopenssl, since that's is what is used in > the condition (BR2_PACKAGE_LIBOPENSSL) > - add a blurb to explain why libopenssl is used, not the virutal > openssl Committed to 2021.02.x and 2020.11.x, thanks.
diff --git a/package/optee-test/optee-test.mk b/package/optee-test/optee-test.mk index 1f4f586672..189956651b 100644 --- a/package/optee-test/optee-test.mk +++ b/package/optee-test/optee-test.mk @@ -10,6 +10,9 @@ OPTEE_TEST_LICENSE = GPL-2.0, BSD-2-Clause, OPTEE_TEST_LICENSE_FILES = LICENSE.md OPTEE_TEST_DEPENDENCIES = optee-client optee-os +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y) +OPTEE_TEST_DEPENDENCIES += openssl +endif OPTEE_TEST_CONF_OPTS = -DOPTEE_TEST_SDK=$(OPTEE_OS_SDK)
Add a dependency on openssl upon BR2_PACKAGE_LIBOPENSSL=y to enable some for OP-TEE embedded tests. Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> --- package/optee-test/optee-test.mk | 3 +++ 1 file changed, 3 insertions(+)