| Message ID | 20200817043431.28718-3-chee.hong.ang@intel.com |
|---|---|
| State | Deferred |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Enable ARM Trusted Firmware for U-Boot | expand |
> -----Original Message----- > From: Ang, Chee Hong <chee.hong.ang@intel.com> > Sent: Monday, August 17, 2020 12:34 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut <marex@denx.de>; Simon Goldschmidt > <simon.k.r.goldschmidt@gmail.com>; Tom Rini <trini@konsulko.com>; See, > Chin Liang <chin.liang.see@intel.com>; Tan, Ley Foon > <ley.foon.tan@intel.com>; Ang, Chee Hong <chee.hong.ang@intel.com>; > Chee, Tien Fong <tien.fong.chee@intel.com>; Lim, Elly Siew Chin > <elly.siew.chin.lim@intel.com> > Subject: [PATCH v1 02/16] arm: socfpga: soc64: Add FIT generator script for > pack itb with ATF > > Generate a FIT image for Intel SOCFPGA (64bits) which include U-boot proper, > ATF and DTB for U-boot proper. > > Signed-off-by: Chee Hong Ang <chee.hong.ang@intel.com> > --- Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>
On Thu, 10 Sep 2020 at 03:45, Tan, Ley Foon <ley.foon.tan@intel.com> wrote: > > > > > -----Original Message----- > > From: Ang, Chee Hong <chee.hong.ang@intel.com> > > Sent: Monday, August 17, 2020 12:34 PM > > To: u-boot@lists.denx.de > > Cc: Marek Vasut <marex@denx.de>; Simon Goldschmidt > > <simon.k.r.goldschmidt@gmail.com>; Tom Rini <trini@konsulko.com>; See, > > Chin Liang <chin.liang.see@intel.com>; Tan, Ley Foon > > <ley.foon.tan@intel.com>; Ang, Chee Hong <chee.hong.ang@intel.com>; > > Chee, Tien Fong <tien.fong.chee@intel.com>; Lim, Elly Siew Chin > > <elly.siew.chin.lim@intel.com> > > Subject: [PATCH v1 02/16] arm: socfpga: soc64: Add FIT generator script for > > pack itb with ATF > > > > Generate a FIT image for Intel SOCFPGA (64bits) which include U-boot proper, > > ATF and DTB for U-boot proper. > > > > Signed-off-by: Chee Hong Ang <chee.hong.ang@intel.com> > > --- > > Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com> NAK Please use binman. There are a few examples now and I can help if needed. Regards, Simon
Hi Simon, > -----Original Message----- > From: Simon Glass <sjg@chromium.org> > Sent: Friday, October 2, 2020 10:10 AM > To: Tan, Ley Foon <ley.foon.tan@intel.com> > Cc: Ang, Chee Hong <chee.hong.ang@intel.com>; u-boot@lists.denx.de; > Marek Vasut <marex@denx.de>; Simon Goldschmidt > <simon.k.r.goldschmidt@gmail.com>; Tom Rini <trini@konsulko.com>; See, > Chin Liang <chin.liang.see@intel.com>; Chee, Tien Fong > <tien.fong.chee@intel.com>; Lim, Elly Siew Chin > <elly.siew.chin.lim@intel.com> > Subject: Re: [PATCH v1 02/16] arm: socfpga: soc64: Add FIT generator script > for pack itb with ATF > > On Thu, 10 Sep 2020 at 03:45, Tan, Ley Foon <ley.foon.tan@intel.com> > wrote: > > > > > > > > > -----Original Message----- > > > From: Ang, Chee Hong <chee.hong.ang@intel.com> > > > Sent: Monday, August 17, 2020 12:34 PM > > > To: u-boot@lists.denx.de > > > Cc: Marek Vasut <marex@denx.de>; Simon Goldschmidt > > > <simon.k.r.goldschmidt@gmail.com>; Tom Rini <trini@konsulko.com>; > > > See, Chin Liang <chin.liang.see@intel.com>; Tan, Ley Foon > > > <ley.foon.tan@intel.com>; Ang, Chee Hong <chee.hong.ang@intel.com>; > > > Chee, Tien Fong <tien.fong.chee@intel.com>; Lim, Elly Siew Chin > > > <elly.siew.chin.lim@intel.com> > > > Subject: [PATCH v1 02/16] arm: socfpga: soc64: Add FIT generator > > > script for pack itb with ATF > > > > > > Generate a FIT image for Intel SOCFPGA (64bits) which include U-boot > > > proper, ATF and DTB for U-boot proper. > > > > > > Signed-off-by: Chee Hong Ang <chee.hong.ang@intel.com> > > > --- > > > > Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com> > > NAK > > Please use binman. There are a few examples now and I can help if needed. > > Regards, > Simon In our flow, we will call "make u-boot.itb" separately after we successfully built u-boot with command "make mrproper, make socfpga_agilex_atf_defconfig; make -j12". Can you please advise the steps or share us the example how to do this using binman? FYI, I am referring to https://github.com/u-boot/u-boot/commit/a32dd071485b17137b6d6088d26cee8011c5b9fc on how to add binman to dts. Thanks, Siew Chin
diff --git a/board/altera/soc64/fit_spl_atf.sh b/board/altera/soc64/fit_spl_atf.sh new file mode 100755 index 0000000000..482ca36f9b --- /dev/null +++ b/board/altera/soc64/fit_spl_atf.sh @@ -0,0 +1,91 @@ +#!/bin/sh +# +# SPDX-License-Identifier: GPL-2.0+ +# +# script to generate FIT image source for Agilex boards with +# U-Boot proper, ATF and device tree for U-Boot proper. +# +# usage: $0 <DT_NAME> + +BL31="bl31.bin" +if [ ! -f $BL31 ]; then + echo "BL31 file \"$BL31\" NOT found!" >&2 + exit 1 +fi + +BL33="u-boot-nodtb.bin" +if [ ! -f $BL33 ]; then + echo "BL33 file \"$BL33\" NOT found!" >&2 + exit 1 +fi + +if [ -f "$1" ] ; then + DT_NAME="$1" +else + echo "File not found: \"$1\"" >&2 + exit 1 +fi + +cat << __PREAMBLE_EOF +/* + * Copyright (C) 2020 Intel Corporation. All rights reserved + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +/dts-v1/; + +/ { + description = "FIT image with U-Boot proper, ATF bl31, U-Boot DTB"; + #address-cells = <1>; + +__PREAMBLE_EOF + +cat << __IMAGES_EOF + images { + uboot { + description = "U-Boot SoC64"; + data = /incbin/("$BL33"); + type = "standalone"; + os = "U-Boot"; + arch = "arm64"; + compression = "none"; + load = <0x00200000>; + }; + + atf { + description = "ARM Trusted Firmware"; + data = /incbin/("$BL31"); + type = "firmware"; + os = "arm-trusted-firmware"; + arch = "arm64"; + compression = "none"; + load = <0x00001000>; + entry = <0x00001000>; + }; + + fdt { + description = "U-Boot SoC64 flat device-tree"; + data = /incbin/("$DT_NAME"); + type = "flat_dt"; + compression = "none"; + }; + }; + +__IMAGES_EOF + +cat << __CONFIGS_EOF + configurations { + default = "conf"; + conf { + description = "Intel SoC64 FPGA"; + firmware = "atf"; + loadables = "uboot"; + fdt = "fdt"; + }; + }; +__CONFIGS_EOF + +cat << __END_EOF +}; +__END_EOF
Generate a FIT image for Intel SOCFPGA (64bits) which include U-boot proper, ATF and DTB for U-boot proper. Signed-off-by: Chee Hong Ang <chee.hong.ang@intel.com> --- board/altera/soc64/fit_spl_atf.sh | 91 +++++++++++++++++++++++++++++++ 1 file changed, 91 insertions(+) create mode 100755 board/altera/soc64/fit_spl_atf.sh