| Message ID | 20200814055425.11316-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | sof-firmware: support 1 and 3 dmics | expand |
On Fri, Aug 14, 2020 at 01:54:24PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1891585 > > [Impact] > On a Dell tigerlake laptop, the sof driver fails to detect the dmic, > it alwasys report 0 dmics on the machine. So users doesn't have > internal mic to use. > > [Fix] > Intel provides 2 new topology files to us, they could support 1 > dmic and 3 dmics. > > [Test Case] > Boot the kernel with this patch, and put sof-hda-generic-1ch.tplg in > the linux-firmware, the sof driver could detect the dmic and users > have a workable internal mic after booting up. > > [Regression Risk] > This is adding 2 new topology files, not changing anything on > current sof-firmware, so the regression posibility is very low. Just to confirm, as we've had problems with sof firmware files in the past due to signing problems. Have you confirmed that these files have been signed appropriately, if they require signatures? Thanks, Seth
On 2020/8/19 上午4:21, Seth Forshee wrote: > On Fri, Aug 14, 2020 at 01:54:24PM +0800, Hui Wang wrote: >> BugLink: https://bugs.launchpad.net/bugs/1891585 >> >> [Impact] >> On a Dell tigerlake laptop, the sof driver fails to detect the dmic, >> it alwasys report 0 dmics on the machine. So users doesn't have >> internal mic to use. >> >> [Fix] >> Intel provides 2 new topology files to us, they could support 1 >> dmic and 3 dmics. >> >> [Test Case] >> Boot the kernel with this patch, and put sof-hda-generic-1ch.tplg in >> the linux-firmware, the sof driver could detect the dmic and users >> have a workable internal mic after booting up. >> >> [Regression Risk] >> This is adding 2 new topology files, not changing anything on >> current sof-firmware, so the regression posibility is very low. > Just to confirm, as we've had problems with sof firmware files in the > past due to signing problems. Have you confirmed that these files have > been signed appropriately, if they require signatures? Confirmed with Intel, all topology files (*.tplg) are not signed by any keys. Only firmware files (*.ri) need to be signed. Thanks, Hui. > > Thanks, > Seth
On Fri, Aug 14, 2020 at 01:54:24PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1891585 > > [Impact] > On a Dell tigerlake laptop, the sof driver fails to detect the dmic, > it alwasys report 0 dmics on the machine. So users doesn't have > internal mic to use. > > [Fix] > Intel provides 2 new topology files to us, they could support 1 > dmic and 3 dmics. > > [Test Case] > Boot the kernel with this patch, and put sof-hda-generic-1ch.tplg in > the linux-firmware, the sof driver could detect the dmic and users > have a workable internal mic after booting up. > > [Regression Risk] > This is adding 2 new topology files, not changing anything on > current sof-firmware, so the regression posibility is very low. Applied for focal and groovy, thanks!