mbox series

[SRU,Unstable/OEM-5.6,0/1] Disable Lenovo P620 Rear line-in volume control

Message ID 20200812082851.14274-1-kai.heng.feng@canonical.com
Headers show
Series Disable Lenovo P620 Rear line-in volume control | expand

Message

Kai-Heng Feng Aug. 12, 2020, 8:28 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1891281

This need to apply after "Add initial audio support for Lenovo
ThinkStation P620":
https://lists.ubuntu.com/archives/kernel-team/2020-August/112479.html

[Impact]
Line-in can't record anything once volume is lower than 80%.

[Fix]
Line-in in general doesn't have AMP, so disable volume control for it.

[Test]
After applying the patch, line-in can always record sound regardless of
volume.

[Regression Potential]
This fix only affects one specific device, furthermore, there's no
real functional change as the fix itself is a quirk.

Kai-Heng Feng (1):
  ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control

 sound/usb/mixer_maps.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Timo Aaltonen Aug. 14, 2020, 12:37 p.m. UTC | #1 
On 12.8.2020 11.28, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1891281
> 
> This need to apply after "Add initial audio support for Lenovo
> ThinkStation P620":
> https://lists.ubuntu.com/archives/kernel-team/2020-August/112479.html
> 
> [Impact]
> Line-in can't record anything once volume is lower than 80%.
> 
> [Fix]
> Line-in in general doesn't have AMP, so disable volume control for it.
> 
> [Test]
> After applying the patch, line-in can always record sound regardless of
> volume.
> 
> [Regression Potential]
> This fix only affects one specific device, furthermore, there's no
> real functional change as the fix itself is a quirk.
> 
> Kai-Heng Feng (1):
>   ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control
> 
>  sound/usb/mixer_maps.c | 1 +
>  1 file changed, 1 insertion(+)
> 

applied to oem-5.6, thanks
Seth Forshee Aug. 14, 2020, 7:59 p.m. UTC | #2 
On Wed, Aug 12, 2020 at 04:28:50PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1891281
> 
> This need to apply after "Add initial audio support for Lenovo
> ThinkStation P620":
> https://lists.ubuntu.com/archives/kernel-team/2020-August/112479.html
> 
> [Impact]
> Line-in can't record anything once volume is lower than 80%.
> 
> [Fix]
> Line-in in general doesn't have AMP, so disable volume control for it.
> 
> [Test]
> After applying the patch, line-in can always record sound regardless of
> volume.
> 
> [Regression Potential]
> This fix only affects one specific device, furthermore, there's no
> real functional change as the fix itself is a quirk.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to groovy/master-next, thanks!