| Message ID | 20200807082343.1506047-1-numans@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,ovn] Fix intermittent failure of system test 29. | expand |
On 8/7/20 10:23 AM, numans@ovn.org wrote: > From: Numan Siddique <numans@ovn.org> > > The below system test is failing due to timing issues. > > 29. system-ovn.at:4491: testing ovn --Test packet drops due to incorrect flows in physical table 33 ... > > This patch fixes it by making sure that the lports are up before sending an ICMP packet. > > Signed-off-by: Numan Siddique <numans@ovn.org> > --- > tests/system-ovn.at | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > index 2af09b4d0b..d43739bd35 100644 > --- a/tests/system-ovn.at > +++ b/tests/system-ovn.at > @@ -4534,6 +4534,10 @@ ADD_NAMESPACES(sw0-p3-f) > ADD_VETH(sw0-p3-f, sw0-p3-f, br-int, "10.0.0.5/24", "10:54:00:00:00:05", \ > "10.0.0.1") > > +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p1-f) = xup]) > +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p2-f) = xup]) > +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p3-f) = xup]) > + > # Send ping from sw0-p1-f to sw0-p3-f > NS_CHECK_EXEC([sw0-p1-f], [ping -q -c 3 -i 0.3 -w 2 10.0.0.5 | FORMAT_PING], \ > [0], [dnl > Looks good to me, thanks! Acked-by: Dumitru Ceara <dceara@redhat.com>
On Fri, Aug 7, 2020 at 3:13 PM Dumitru Ceara <dceara@redhat.com> wrote: > > On 8/7/20 10:23 AM, numans@ovn.org wrote: > > From: Numan Siddique <numans@ovn.org> > > > > The below system test is failing due to timing issues. > > > > 29. system-ovn.at:4491: testing ovn --Test packet drops due to incorrect flows in physical table 33 ... > > > > This patch fixes it by making sure that the lports are up before sending an ICMP packet. > > > > Signed-off-by: Numan Siddique <numans@ovn.org> > > --- > > tests/system-ovn.at | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > > index 2af09b4d0b..d43739bd35 100644 > > --- a/tests/system-ovn.at > > +++ b/tests/system-ovn.at > > @@ -4534,6 +4534,10 @@ ADD_NAMESPACES(sw0-p3-f) > > ADD_VETH(sw0-p3-f, sw0-p3-f, br-int, "10.0.0.5/24", "10:54:00:00:00:05", \ > > "10.0.0.1") > > > > +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p1-f) = xup]) > > +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p2-f) = xup]) > > +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p3-f) = xup]) > > + > > # Send ping from sw0-p1-f to sw0-p3-f > > NS_CHECK_EXEC([sw0-p1-f], [ping -q -c 3 -i 0.3 -w 2 10.0.0.5 | FORMAT_PING], \ > > [0], [dnl > > > > Looks good to me, thanks! > > Acked-by: Dumitru Ceara <dceara@redhat.com> Thanks Dumitru. I applied this patch to master. Numan > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/tests/system-ovn.at b/tests/system-ovn.at index 2af09b4d0b..d43739bd35 100644 --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -4534,6 +4534,10 @@ ADD_NAMESPACES(sw0-p3-f) ADD_VETH(sw0-p3-f, sw0-p3-f, br-int, "10.0.0.5/24", "10:54:00:00:00:05", \ "10.0.0.1") +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p1-f) = xup]) +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p2-f) = xup]) +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p3-f) = xup]) + # Send ping from sw0-p1-f to sw0-p3-f NS_CHECK_EXEC([sw0-p1-f], [ping -q -c 3 -i 0.3 -w 2 10.0.0.5 | FORMAT_PING], \ [0], [dnl