From patchwork Fri Aug 7 08:23:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Numan Siddique X-Patchwork-Id: 1342139 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BNJKt26dwz9sPB for ; Fri, 7 Aug 2020 18:24:02 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 051D487278; Fri, 7 Aug 2020 08:24:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3FWoOSKOpADV; Fri, 7 Aug 2020 08:23:56 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 66207870EF; Fri, 7 Aug 2020 08:23:56 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 55EDFC0050; Fri, 7 Aug 2020 08:23:56 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6D109C004C for ; Fri, 7 Aug 2020 08:23:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5A5478884F for ; Fri, 7 Aug 2020 08:23:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 47qj+rvVhaIM for ; Fri, 7 Aug 2020 08:23:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by hemlock.osuosl.org (Postfix) with ESMTPS id 3493F88841 for ; Fri, 7 Aug 2020 08:23:53 +0000 (UTC) X-Originating-IP: 27.7.97.20 Received: from nusiddiq.home.org.home.org (unknown [27.7.97.20]) (Authenticated sender: numans@ovn.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 49128240004; Fri, 7 Aug 2020 08:23:48 +0000 (UTC) From: numans@ovn.org To: dev@openvswitch.org Date: Fri, 7 Aug 2020 13:53:43 +0530 Message-Id: <20200807082343.1506047-1-numans@ovn.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH ovn] Fix intermittent failure of system test 29. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Numan Siddique The below system test is failing due to timing issues. 29. system-ovn.at:4491: testing ovn --Test packet drops due to incorrect flows in physical table 33 ... This patch fixes it by making sure that the lports are up before sending an ICMP packet. Signed-off-by: Numan Siddique Acked-by: Dumitru Ceara --- tests/system-ovn.at | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index 2af09b4d0b..d43739bd35 100644 --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -4534,6 +4534,10 @@ ADD_NAMESPACES(sw0-p3-f) ADD_VETH(sw0-p3-f, sw0-p3-f, br-int, "10.0.0.5/24", "10:54:00:00:00:05", \ "10.0.0.1") +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p1-f) = xup]) +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p2-f) = xup]) +OVS_WAIT_UNTIL([test x$(ovn-nbctl lsp-get-up sw0-p3-f) = xup]) + # Send ping from sw0-p1-f to sw0-p3-f NS_CHECK_EXEC([sw0-p1-f], [ping -q -c 3 -i 0.3 -w 2 10.0.0.5 | FORMAT_PING], \ [0], [dnl