diff mbox series

[1/4] package/poco: fix the comment dependencies about riscv

Message ID 20200629210735.179913-1-juju@cotds.org
State Superseded
Headers show
Series [1/4] package/poco: fix the comment dependencies about riscv | expand

Commit Message

Julien Olivain June 29, 2020, 9:07 p.m. UTC
Commit 0737f48c5f "package/poco: disable build for riscv"
changed the Kconfig package dependency, without updating the dependency
of the comment. This patch set the comment dependency to the same
condition as the package.

Signed-off-by: Julien Olivain <juju@cotds.org>
---
 package/poco/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni June 29, 2020, 9:17 p.m. UTC | #1
On Mon, 29 Jun 2020 23:07:32 +0200
Julien Olivain <juju@cotds.org> wrote:

> Commit 0737f48c5f "package/poco: disable build for riscv"
> changed the Kconfig package dependency, without updating the dependency
> of the comment. This patch set the comment dependency to the same
> condition as the package.
> 
> Signed-off-by: Julien Olivain <juju@cotds.org>

We really want to introduce a BR2_PACKAGE_POCO_ARCH_SUPPORTS option so
that those architecture dependencies are not repeated.

You can grep for BR2_PACKAGE_.*_ARCH_SUPPORTS to see other uses of that
pattern.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/poco/Config.in b/package/poco/Config.in
index f8f921de04..df37e53b53 100644
--- a/package/poco/Config.in
+++ b/package/poco/Config.in
@@ -86,4 +86,4 @@  comment "poco needs a toolchain w/ wchar, NPTL, C++, dynamic library"
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP \
 		|| !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
 	depends on !(BR2_arc || BR2_microblaze || BR2_mipsel \
-		|| BR2_or1k || BR2_xtensa)
+		|| BR2_or1k || BR2_riscv || BR2_xtensa)