diff mbox series

[v3,6/7] package/gupnp: Depend on host-vala if gobject-introspection is selected.

Message ID 20200327183000.1005676-6-aduskett@gmail.com
State Accepted
Headers show
Series [v3,1/7] package/vala/vala-wrapper: fix wrapper | expand

Commit Message

Adam Duskett March 27, 2020, 6:29 p.m. UTC 
From: Adam Duskett <Aduskett@gmail.com>

Because there is no way to select host-vala explicitly and some packages may
require the vala bindings, it is better to unconditionally build the vala
bindings into the .gir and .typelib files.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/gupnp/gupnp.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Yann E. MORIN March 31, 2020, 9:17 p.m. UTC | #1 
Adam, All,

On 2020-03-27 11:29 -0700, aduskett@gmail.com spake thusly:
> From: Adam Duskett <Aduskett@gmail.com>
> 
> Because there is no way to select host-vala explicitly and some packages may
> require the vala bindings, it is better to unconditionally build the vala
> bindings into the .gir and .typelib files.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>

Applied to master with a tweaked comit log, thanks!

Regards,
Yann E. MORIN.

> ---
>  package/gupnp/gupnp.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/gupnp/gupnp.mk b/package/gupnp/gupnp.mk
> index 612359ba55..c86eb6db2c 100644
> --- a/package/gupnp/gupnp.mk
> +++ b/package/gupnp/gupnp.mk
> @@ -14,10 +14,10 @@ GUPNP_INSTALL_STAGING = YES
>  GUPNP_DEPENDENCIES = host-pkgconf libglib2 libxml2 gssdp util-linux
>  
>  ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> -GUPNP_CONF_OPTS += -Dintrospection=true
> -GUPNP_DEPENDENCIES += gobject-introspection
> +GUPNP_CONF_OPTS += -Dintrospection=true -Dvapi=true
> +GUPNP_DEPENDENCIES += host-vala gobject-introspection
>  else
> -GUPNP_CONF_OPTS += -Dintrospection=false
> +GUPNP_CONF_OPTS += -Dintrospection=false -Dvapi=false
>  endif
>  
>  $(eval $(meson-package))
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/gupnp/gupnp.mk b/package/gupnp/gupnp.mk
index 612359ba55..c86eb6db2c 100644
--- a/package/gupnp/gupnp.mk
+++ b/package/gupnp/gupnp.mk
@@ -14,10 +14,10 @@  GUPNP_INSTALL_STAGING = YES
 GUPNP_DEPENDENCIES = host-pkgconf libglib2 libxml2 gssdp util-linux
 
 ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
-GUPNP_CONF_OPTS += -Dintrospection=true
-GUPNP_DEPENDENCIES += gobject-introspection
+GUPNP_CONF_OPTS += -Dintrospection=true -Dvapi=true
+GUPNP_DEPENDENCIES += host-vala gobject-introspection
 else
-GUPNP_CONF_OPTS += -Dintrospection=false
+GUPNP_CONF_OPTS += -Dintrospection=false -Dvapi=false
 endif
 
 $(eval $(meson-package))