| Message ID | 20181102211707.10229-1-linux@rasmusvillemoes.dk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3775026a654c15c92c8ac2d53f3fd14fdd1980df |
| Headers | show |
| Series | macintosh: ans-lcd: make anslcd_logo static and __initconst | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/checkpatch | success | Test checkpatch on branch next |
| snowpatch_ozlabs/build-ppc64le | success | Test build-ppc64le on branch next |
| snowpatch_ozlabs/build-ppc64be | success | Test build-ppc64be on branch next |
| snowpatch_ozlabs/build-ppc64e | success | Test build-ppc64e on branch next |
| snowpatch_ozlabs/build-ppc32 | success | Test build-ppc32 on branch next |
On Fri, 2018-11-02 at 21:17:06 UTC, Rasmus Villemoes wrote: > This variable has no reason to have external linkage, and since it is > only used in an __init function, it might as well be made __initconst > also. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/3775026a654c15c92c8ac2d53f3fd14fdd1980df cheers
diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c index c8e078b911c7..a7a79a935f6a 100644 --- a/drivers/macintosh/ans-lcd.c +++ b/drivers/macintosh/ans-lcd.c @@ -147,7 +147,8 @@ static struct miscdevice anslcd_dev = { &anslcd_fops }; -const char anslcd_logo[] = "********************" /* Line #1 */ +static const char anslcd_logo[] __initconst = + "********************" /* Line #1 */ "* LINUX! *" /* Line #3 */ "* Welcome to *" /* Line #2 */ "********************"; /* Line #4 */
This variable has no reason to have external linkage, and since it is only used in an __init function, it might as well be made __initconst also. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- drivers/macintosh/ans-lcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)