| Message ID | 1569318169-12327-1-git-send-email-Anson.Huang@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] pwm: pwm-mxs: use devm_platform_ioremap_resource() to simplify code | expand |
On Tue, Sep 24, 2019 at 05:42:48PM +0800, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > - This is a resend version of patch: https://patchwork.kernel.org/patch/11048365/ > --- > drivers/pwm/pwm-mxs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) When you do resend patches, please make sure to include an Reviewed-by or Acked-by tags that you get. In this case that's not necessary since I had already applied the other patch. Thierry > > diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c > index 04c0f6b..b14376b 100644 > --- a/drivers/pwm/pwm-mxs.c > +++ b/drivers/pwm/pwm-mxs.c > @@ -126,15 +126,13 @@ static int mxs_pwm_probe(struct platform_device *pdev) > { > struct device_node *np = pdev->dev.of_node; > struct mxs_pwm_chip *mxs; > - struct resource *res; > int ret; > > mxs = devm_kzalloc(&pdev->dev, sizeof(*mxs), GFP_KERNEL); > if (!mxs) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - mxs->base = devm_ioremap_resource(&pdev->dev, res); > + mxs->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mxs->base)) > return PTR_ERR(mxs->base); > > -- > 2.7.4 >
diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c index 04c0f6b..b14376b 100644 --- a/drivers/pwm/pwm-mxs.c +++ b/drivers/pwm/pwm-mxs.c @@ -126,15 +126,13 @@ static int mxs_pwm_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; struct mxs_pwm_chip *mxs; - struct resource *res; int ret; mxs = devm_kzalloc(&pdev->dev, sizeof(*mxs), GFP_KERNEL); if (!mxs) return -ENOMEM; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - mxs->base = devm_ioremap_resource(&pdev->dev, res); + mxs->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(mxs->base)) return PTR_ERR(mxs->base);
Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- - This is a resend version of patch: https://patchwork.kernel.org/patch/11048365/ --- drivers/pwm/pwm-mxs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)